Bug 228658
| Summary: | sysutils/monit enhancement suggestions with patch for pam option and statefile placement | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | dewayne | ||||
| Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | danfe, martinp | ||||
| Priority: | --- | Flags: | martinp:
maintainer-feedback-
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks for the patch. - The PAM option looks fine - The change of the state directory is dangerous though, as it saves a state file ... if it changes after upgrade, Monit will have state "amnesia" and for example services that were intentionally disabled by the user will be enabled again, which may be problem for example in active/passive cluster setup => please remove it from the patch - The patch also changes CONFIGURE_ARGS option, which is not present in the current port Makefile, so the patch failed when i tried to test it ... the --enable-optimized is useful though, please can you fix the patch? Best regards, Martin Comment on attachment 193886 [details]
Disable PAM option and define statefile location
Thanks for the patch.
- The PAM option looks fine
- The change of the state directory is dangerous though, as it saves a state file ... if it changes after upgrade, Monit will have state "amnesia" and for example services that were intentionally disabled by the user will be enabled again, which may be problem for example in active/passive cluster setup => please remove it from the patch
- The patch also changes CONFIGURE_ARGS option, which is not present in the current port Makefile, so the patch failed when i tried to test it ... the --enable-optimized is useful though, please can you fix the patch?
Best regards,
Martin
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2924196da02e8dbf43d114d8edb0974154822835 commit 2924196da02e8dbf43d114d8edb0974154822835 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2021-07-14 10:48:58 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2021-07-14 10:49:09 +0000 sysutils/monit: allow to build without PAM support. PR: 228658 sysutils/monit/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) |
Created attachment 193886 [details] Disable PAM option and define statefile location As PAM isn't required, I modified the monit/Makefile to enable this option. While there I also enable the choice of where the statedir should be. Unfortunately I also unsuccessfully tried to build with static and with ipv6.