Bug 228658

Summary: sysutils/monit enhancement suggestions with patch for pam option and statefile placement
Product: Ports & Packages Reporter: dewayne
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: New ---    
Severity: Affects Only Me CC: martinp
Priority: --- Flags: martinp: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Disable PAM option and define statefile location none

Description dewayne 2018-06-01 04:39:16 UTC
Created attachment 193886 [details]
Disable PAM option and define statefile location

As PAM isn't required, I modified the monit/Makefile to enable this option.  While there I also enable the choice of where the statedir should be.

Unfortunately I also unsuccessfully tried to build with static and with ipv6.
Comment 1 martinp 2018-07-30 19:44:18 UTC
Thanks for the patch.

- The PAM option looks fine

- The change of the state directory is dangerous though, as it saves a state file ... if it changes after upgrade, Monit will have state "amnesia" and for example services that were intentionally disabled by the user will be enabled again, which may be problem for example in active/passive cluster setup => please remove it from the patch

- The patch also changes CONFIGURE_ARGS option, which is not present in the current port Makefile, so the patch failed when i tried to test it ... the --enable-optimized is useful though, please can you fix the patch?

Best regards,
Martin
Comment 2 martinp 2018-07-30 19:49:10 UTC
Comment on attachment 193886 [details]
Disable PAM option and define statefile location

Thanks for the patch.

- The PAM option looks fine

- The change of the state directory is dangerous though, as it saves a state file ... if it changes after upgrade, Monit will have state "amnesia" and for example services that were intentionally disabled by the user will be enabled again, which may be problem for example in active/passive cluster setup => please remove it from the patch

- The patch also changes CONFIGURE_ARGS option, which is not present in the current port Makefile, so the patch failed when i tried to test it ... the --enable-optimized is useful though, please can you fix the patch?

Best regards,
Martin