Bug 228712

Summary: www/aria2: add asynchronous DNS support via libcares
Product: Ports & Packages Reporter: yorik.sar+rerFlEJcdSDuqrOxzVrAbdzsrs
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: lightside, sunpoet
Priority: --- Flags: bugzilla: maintainer-feedback? (sunpoet)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to add async DNS support
none
Proposed patch (since 471508 revision) lightside: maintainer-approval? (sunpoet)

Description yorik.sar+rerFlEJcdSDuqrOxzVrAbdzsrs 2018-06-02 23:18:17 UTC
Created attachment 193952 [details]
patch to add async DNS support

I've ran into necessity to use async DNS feature, but it was disabled at compile time, from the looks of it from the dawn of ages.

Attached patch seems to be working fine for me.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-06-03 18:17:43 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Jun  3 18:17:29 UTC 2018
New revision: 471508
URL: https://svnweb.freebsd.org/changeset/ports/471508

Log:
  Add CARES option

  PR:		228712
  Submtited by:	<yorik.sar@gmail.com>

Changes:
  head/www/aria2/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-06-03 18:18:10 UTC
Committed. Thanks!
Comment 3 yorik.sar+rerFlEJcdSDuqrOxzVrAbdzsrs 2018-06-03 18:27:58 UTC
Thanks for a swift reply! I didn't know there's already an option defined for libcares. Cool :)
Comment 4 lightside 2018-06-04 14:45:23 UTC
Created attachment 193995 [details]
Proposed patch (since 471508 revision)

(In reply to comment #1)
There is --without-libcares configure option:
-8<--
% ./configure --help | grep ares
  --without-libcares      Do not use libcares. [default=check]
-->8-

The attachment #193952 [details] contains correct option's name.
Attached patch after ports r471508 changes.

- Rename libares to libcares for CARES_CONFIGURE_WITH variable
Comment 5 lightside 2018-06-04 14:55:22 UTC
(In reply to comment #4)
How to check:
-8<--
% sh -c "make WITHOUT=CARES clean configure 2>&1" | grep ^LibCares
LibCares:       no (CFLAGS='' LIBS='')
% sh -c "make WITH=CARES clean configure 2>&1" | grep ^LibCares
LibCares:       yes (CFLAGS='-I/usr/local/include ' LIBS='-L/usr/local/lib -lcares ')
% make clean
<..>
-->8-
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-06-04 16:36:20 UTC
(In reply to lightside from comment #4)

Fixed in r471562. Thanks!