Bug 228715
| Summary: | Add a note to the Porter's Handbook that "Created by: ..." should not be present in Makefiles of new ports | ||
|---|---|---|---|
| Product: | Documentation | Reporter: | Mateusz Piotrowski <0mp> |
| Component: | Books & Articles | Assignee: | freebsd-doc (Nobody) <doc> |
| Status: | Closed Not A Bug | ||
| Severity: | Affects Only Me | CC: | adamw, linimon, miwi, portmgr, ports-bugs |
| Priority: | --- | Keywords: | easy, needs-qa |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Mateusz Piotrowski
2018-06-03 01:54:37 UTC
Do we need to include text for what not to include? Are people still writing it? Interestingly, 21789/33297 (65%) of Makefiles still have such a line. Perhaps its time to just remove them entirely. (In reply to Eitan Adler from comment #2) We should probably also teach portlint to bark on such lines. (In reply to Eitan Adler from comment #2) I think the policy is "remove them if you happen to be committing to the Makefile otherwise"? (In reply to Mark Linimon from comment #4) Yes that was the the current way. I'm fine with a note saying that "Created by:" is optional, or even discouraged, but I remain firmly opposed to banning it. (In reply to Mark Linimon from comment #4) The current policy, as I understand it, is that they should never be removed without permission from the listed name. Nobody said it was banned, nobody said it was forbidden. As it serves no functional purpose, it is simply not required, so it is not documented. |