Bug 228820

Summary: Incorrect value of ARG_TERMID_ADDR in sys/security/audit/audit.h
Product: Base System Reporter: Aniket Pandey <aniketp>
Component: kernAssignee: Alan Somers <asomers>
Status: Closed FIXED    
Severity: Affects Some People CC: asomers, emaste
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   

Description Aniket Pandey 2018-06-08 03:39:23 UTC
The definition of "ARG_TERMID_ADDR" macro assigns it a value of

0x0000000000400000ULL

which is already assigned to "ARG_SADDRUNIX" a line above.

This change was accidentally introduced in rS168688.
https://reviews.freebsd.org/rS168688


Please See: https://github.com/freebsd/freebsd/blob/7c423a65c91bf1b002e8f1f6f0f8bfa9beefcc9c/sys/security/audit/audit_private.h#L278
Comment 1 commit-hook freebsd_committer 2018-06-13 14:55:48 UTC
A commit references this bug:

Author: asomers
Date: Wed Jun 13 14:55:32 UTC 2018
New revision: 335060
URL: https://svnweb.freebsd.org/changeset/base/335060

Log:
  audit(4): fix the definition of ARG_TERMID_ADDR

  Due to a copy/paste error in r168688, ARG_TERMID_ADDR has the same
  definition as ARG_SADDRUNIX.  Fix it.

  The header change, while publicly visible, is guarded by #ifdef KERNEL, and
  I can't find any kmod ports that use it.  So I'm not bumping
  __FreeBSD_version.

  PR:		228820
  Submitted by:	aniketp
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D15702

Changes:
  head/sys/security/audit/audit_private.h
Comment 2 Ed Maste freebsd_committer 2019-06-09 10:55:31 UTC
MFC?
Comment 3 Alan Somers freebsd_committer 2019-06-09 13:18:42 UTC
Sure.
Comment 4 commit-hook freebsd_committer 2019-06-15 23:01:06 UTC
A commit references this bug:

Author: asomers
Date: Sat Jun 15 23:00:24 UTC 2019
New revision: 349087
URL: https://svnweb.freebsd.org/changeset/base/349087

Log:
  MFC r335060

  audit(4): fix the definition of ARG_TERMID_ADDR

  Due to a copy/paste error in r168688, ARG_TERMID_ADDR has the same
  definition as ARG_SADDRUNIX.  Fix it.

  The header change, while publicly visible, is guarded by #ifdef KERNEL, and
  I can't find any kmod ports that use it.  So I'm not bumping
  __FreeBSD_version.

  PR:		228820
  Submitted by:	aniketp
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D15702

Changes:
_U  stable/11/
  stable/11/sys/security/audit/audit_private.h