Summary: | [UPDATE] net/ipxe: update to 20180514 & fix embedding of custom trusted certs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Chad Jacob Milios <milios> | ||||||
Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | Flags: | tobik:
maintainer-feedback+
|
||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Chad Jacob Milios
2018-06-08 20:29:35 UTC
Created attachment 194110 [details]
ipxe.diff
I can confirm the csplit problem, but it makes no sense to add a
coreutils build dependency to the ISO option. The certificate is
embdedded into every image net/ipxe builds not only the ISO.
We also only need this when CERT= is set in MAKE_ARGS, so let's
only add it in that case. Not everyone needs it.
Please try with the attached patch instead.
Yeah, that line being added only within ISO_* was an oversight and mistake. Your make-fu is much nicer with the conditional dependency; that's exactly what I wanted to do but I wasn't sure how. I was also unsure whether it was CERT or TRUST which triggered csplit, as I am using both. I've since tested your patch every different way I know how and can report it seems perfect to me. (I see you didn't need the extra patch-Makefile and I got rid of it first too.) Thank you so much for the super quick turnaround on this, maintainer! A commit references this bug: Author: tobik Date: Sun Jun 10 10:02:56 UTC 2018 New revision: 472124 URL: https://svnweb.freebsd.org/changeset/ports/472124 Log: net/ipxe: Update to latest commit Pull in gcsplit from sysutils/coreutils when users try to embed certificates via CERT= in MAKE_ARGS. This currently fails because iPXE expects csplit to behave like GNU csplit and uses constructs that our csplit does not support. PR: 228835 Submitted by: Chad Jacob Milios <milios@ccsys.com> (based on) Changes: head/net/ipxe/Makefile head/net/ipxe/distinfo Committed. Thanks! |