Bug 228972

Summary: Please package emulators/ppsspp with the customized ffmpeg shipped instead of multimedia/ffmpeg
Product: Ports & Packages Reporter: ldbeth
Component: Individual Port(s)Assignee: freebsd-ports-bugs mailing list <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: eadler, jbeich, multimedia
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description ldbeth 2018-06-13 05:53:39 UTC
The offical ffmpeg lacks some codec needed to play video CGs in PSP games, which causes videos to be broken in PPSSPP. Instead PPSSPP uses its slimmed-down build of ffmpeg.

https://github.com/hrydgard/ppsspp/issues/11173

I'm new to FreeBSD's port so I don't know if it is more proper to leave a seperate port to that version of ffmpeg or directly include into emulators/ppsspp.

Thanks in advance.
Comment 1 commit-hook freebsd_committer 2018-06-13 12:33:31 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jun 13 12:33:14 UTC 2018
New revision: 472312
URL: https://svnweb.freebsd.org/changeset/ports/472312

Log:
  emulators/ppsspp: unbreak in-game movies

  PR:		228972

Changes:
  head/emulators/ppsspp/Makefile
  head/emulators/ppsspp/distinfo
  head/emulators/ppsspp/files/pkg-message.in
Comment 2 commit-hook freebsd_committer 2018-06-13 13:26:26 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jun 13 13:26:09 UTC 2018
New revision: 472320
URL: https://svnweb.freebsd.org/changeset/ports/472320

Log:
  MFH: r472312 r472319

  emulators/ppsspp: unbreak in-game movies

  PR:		228972
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q2/
  branches/2018Q2/emulators/ppsspp/Makefile
  branches/2018Q2/emulators/ppsspp/distinfo
  branches/2018Q2/emulators/ppsspp/files/pkg-message.in
  branches/2018Q2/emulators/ppsspp-qt5/Makefile
Comment 3 Jan Beich freebsd_committer 2018-06-13 13:43:55 UTC
Adding support for bundled ffmpeg requires a lot of QA:
- FreeBSD port supports 10.4, 11.1, 11.2, 12.0; amd64, i386, aarch64, armv6, armv7
- DragonFly port uses FreeBSD port as a base (currently no modifications)
  https://github.com/DragonFlyBSD/DeltaPorts/tree/master/ports/emulators/ppsspp/
- linking against pre-built binaries undermines trust and hinders debugging
- https://www.freebsd.org/doc/en/books/porters-handbook/bundled-libs.html

Anyway, closing this one unless you can still reproduce. If so report which games are affected.