Bug 229056

Summary:	Use more informative term for Phabricator in header entities
Product:	Documentation	Reporter:	Guangyuan Yang <ygy>
Component:	Website	Assignee:	Eitan Adler <eadler>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	delphij, eadler, trasz
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description Guangyuan Yang freebsd_committer

2018-06-15 23:52:22 UTC

Recently, link of Phabricator has been added to the header with description "Phabricator". It might be confusing for a newcomer what "Phabricator" is, so we could probably use more informative terms like "Phabricator Review System", etc.

https://svnweb.freebsd.org/doc/head/share/xml/header.ent?r1=51804&r2=51827

Comment 1 Eitan Adler freebsd_committer

2018-06-16 00:19:01 UTC

Perhaps "Code Review (Phabricator)"

Comment 2 Guangyuan Yang freebsd_committer

2018-06-16 01:00:55 UTC

(In reply to Eitan Adler from comment #1)

One concern: Currently the longest name in the list is "SVN Repository" which takes 13 characters. Will a long string as "Code Review (Phabricator)" fit in there well?

Comment 3 Eitan Adler freebsd_committer

2018-06-16 04:17:31 UTC

Good call. I just checked, and it wraps around, so it's fine.

Comment 4 commit-hook freebsd_committer

2018-06-16 04:20:00 UTC

A commit references this bug:

Author: eadler
Date: Sat Jun 16 04:19:45 UTC 2018
New revision: 51840
URL: https://svnweb.freebsd.org/changeset/doc/51840

Log:
  www: update development resources

  - make it clear phab is for code review
  - Git shouldn't be capitalized
  - make it clear that the git repo is a mirror

  Submitted by:	ygy
  PR:		229056

Changes:
  head/share/xml/header.ent

Comment 5 Guangyuan Yang freebsd_committer

2018-06-16 05:45:50 UTC

Thank you!