Bug 229074
| Summary: | [acpi_ibm] [patch] Add support for Thinkpads Mic led | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Ali Abdallah <ali.abdallah> | ||||||||||
| Component: | misc | Assignee: | freebsd-acpi (Nobody) <acpi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Many People | CC: | ali.abdallah, eadler | ||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||
| Version: | 11.0-STABLE | ||||||||||||
| Hardware: | amd64 | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Hey, the patch doesn't apply. Can you resend? Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- file_not_specified_in_diff |+++ file_not_specified_in_diff -------------------------- Patching file ./sys/dev/acpi_support/acpi_ibm.c using Plan A... Empty context always matches. Reversed (or previously applied) patch detected! Assume -R? [y] y Hunk #1 succeeded at 77. Empty context always matches. Hunk #2 succeeded at 179. patch: **** malformed patch at line 16: --- Created attachment 194338 [details]
Add support for microphone led
New patch uploaded, let me know if it is okay. It applies on my system. A commit references this bug: Author: eadler Date: Sun Jun 17 20:44:21 UTC 2018 New revision: 335304 URL: https://svnweb.freebsd.org/changeset/base/335304 Log: acpi: Add support for Thinkpads Mic led PR: 229074 Submitted by: "Ali Abdallah" <aliovx@gmail.com> Changes: head/sys/dev/acpi_support/acpi_ibm.c Created attachment 195237 [details]
Add documentation of dev.acpi_ibm.0.mic_led
I've added documentation of the dev.acpi_ibm.0.mic_led, as well as example how to use it in /usr/local/sbin/acpi_oem_exec.sh to the acpi_ibm.4. Please kindly apply it.
Created attachment 195325 [details]
Add documentation of dev.acpi_ibm.0.mic_led
Small correction.
A commit references this bug: Author: allanjude Date: Sat Jan 12 17:52:52 UTC 2019 New revision: 342971 URL: https://svnweb.freebsd.org/changeset/base/342971 Log: Add missing documentation for dev.acpi_ibm.0.mic_led added in r335304 PR: 229074 X-MFC-With: 335304 Submitted by: Ali Abdallah <aliovx@gmail.com> Changes: head/share/man/man4/acpi_ibm.4 |
Created attachment 194314 [details] Add support for microphone led The acpi_ibm kernel module does not have a syscall to control the microphone led state (for example on x220 and x230 thinkpads). The attached patch adds a dev.acpi_ibm.0.mic_led=0 (off) 1 (on) sysctl, the led is controlled using the ACPI MMTS Object.