Bug 229116

Summary: science/paraview: Conflict with protobuf
Product: Ports & Packages Reporter: Jason W. Bacon <jwb>
Component: Individual Port(s)Assignee: Jason W. Bacon <jwb>
Status: Closed FIXED    
Severity: Affects Some People CC: devel
Priority: --- Flags: bugzilla: maintainer-feedback? (devel)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for update port science/paraview to version 5.5.1 and fix build with system devel/protobuf installed none

Description Jason W. Bacon freebsd_committer freebsd_triage 2018-06-18 17:17:39 UTC 
[38/58] Upgrading paraview from 5.2.0_4 to 5.5.0...
pkg: paraview-5.5.0 conflicts with protobuf-3.5.2 (installs files into the same place).  Problematic file: /usr/local/lib/libprotobuf-lite.so

This is a real issue as protobuf has many dependencies, including some that people will certainly want installed alongside paraview.

Example from my office workstation:

root@outpaddling:/home/bacon # pkg remove protobuf
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 7 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	protobuf-3.5.2
	opencv-core-3.4.1_1
	ffmpeg-4.0_1,1
	kf5-kfilemetadata-5.46.0
	thunderbird-52.8.0_5
	firefox-60.0.2,1
	k3b-18.04.1_1
Comment 1 devel 2018-06-21 08:56:48 UTC 
Hello ! 

1) This is "old" conflict with protobuf, CONFLICTS_BUILD required also now.

2) There is a one real chain of dependencies in this case, but it creates with default KNOBS (it's a pity):
many applications-->ffmpeg--->opencv-core--->protobuf

3) I'll try to fix conflict paraview vs. protobuf.
Comment 2 devel 2018-06-22 10:22:14 UTC 
Created attachment 194479 [details]
patch for update port science/paraview to version  5.5.1 and fix build with system devel/protobuf installed
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2018-06-22 15:49:51 UTC 
For some reason, your patch dropped patch-CommandLineExecutables_CMakeLists.txt in the top level dir instead of files, but once I realized that and put it where it belonged, the port built cleanly.

Thanks for the quick resolution.
Comment 4 Jason W. Bacon freebsd_committer freebsd_triage 2018-06-22 15:51:20 UTC 
If you're satisfied with the patch, I'll gladly do the commit.
Comment 5 devel 2018-06-22 16:16:47 UTC 
(In reply to Jason W. Bacon from comment #4)
Ok, let's commit it.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-06-27 00:05:23 UTC 
A commit references this bug:

Author: jwb
Date: Wed Jun 27 00:04:30 UTC 2018
New revision: 473414
URL: https://svnweb.freebsd.org/changeset/ports/473414

Log:
  science/paraview: Fix protobuf conflict, upgrade to 5.5.1, modernize options

  PR:             229116
  Reported by:    jwb
  Approved by:    jrm (mentor)
  Differential Revision:  https://reviews.freebsd.org/D16024

Changes:
  head/science/paraview/Makefile
  head/science/paraview/distinfo
  head/science/paraview/files/patch-CommandLineExecutables_CMakeLists.txt
  head/science/paraview/files/patch-ParaViewCore_ClientServerCore_Default_vtkPVFileInformation.h
  head/science/paraview/files/patch-ParaViewCore_VTKExtensions_Default_vtkPhastaReader.cxx
  head/science/paraview/files/patch-Plugins_CDIReader_cdilib.c
  head/science/paraview/files/patch-VTK_IO_EnSight_vtkEnSight6BinaryReader.cxx
  head/science/paraview/files/patch-VTK_IO_EnSight_vtkEnSightGoldBinaryReader.cxx
  head/science/paraview/files/patch-vtkEnSight6BinaryReader.cxx
  head/science/paraview/files/patch-vtkEnSightGoldBinaryReader.cxx
  head/science/paraview/files/patch-vtkPVFileInformation.h
  head/science/paraview/files/patch-vtkPhastaReader.cxx
  head/science/paraview/pkg-plist
Comment 7 Jason W. Bacon freebsd_committer freebsd_triage 2018-06-27 00:08:28 UTC 
Committedm with additional changes:

- Modernized options
- Standardized patch file names