Bug 229198

Summary: net-im/uTox: Update to 0.17.0
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: portmaster
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (portmaster)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
utox.diff
portmaster: maintainer-approval-
svn diff for net-im/uTox (0.17) portmaster: maintainer-approval+

Description Tobias Kortkamp freebsd_committer 2018-06-21 09:30:13 UTC
Created attachment 194449 [details]
utox.diff

Hi,

the current version of uTox 0.11.0 seems to segfault for me.  Updating
it to 0.17.0 fixes this.  It also works with net-im/tox now instead
of net-im/tox12, which means that tox12 can be probably be removed
from the ports tree after this lands.

Changelog: https://github.com/uTox/uTox/releases

I'd also like to request maintainership of uTox.

Builds fine in Poudriere for 11.1/amd64, 10.4/i386, 12.0/amd64
Comment 1 Chris Hutchinson 2018-06-21 17:23:34 UTC
Created attachment 194466 [details]
svn diff for net-im/uTox (0.17)

An alternate patch to upgrade net-im/uTox to version 0.17
Comment 2 Chris Hutchinson 2018-06-21 17:26:17 UTC
Comment on attachment 194449 [details]
utox.diff

This patch has several issues.
Please see the dialog, and proposed (alternate) patch
associated with this pr(1).

--Chris
Comment 3 Tobias Kortkamp freebsd_committer 2018-06-21 17:41:03 UTC
(In reply to Chris Hutchinson from comment #2)
So it's the same patch except for some changes in the LICENSE block?

GPLv3 was in there because the developers claim that sections of the code
might still be GPLv3 licensed.  See https://github.com/uTox/uTox/blob/develop/LICENSE.
Comment 4 Chris Hutchinson 2018-06-21 17:50:24 UTC
(In reply to Tobias Kortkamp from comment #0)
> Created attachment 194449 [details]
> utox.diff
> 
> Hi,
> 
> the current version of uTox 0.11.0 seems to segfault for me.  Updating
> it to 0.17.0 fixes this.  It also works with net-im/tox now instead
> of net-im/tox12, which means that tox12 can be probably be removed
> from the ports tree after this lands.
> 
> Changelog: https://github.com/uTox/uTox/releases
> 
> I'd also like to request maintainership of uTox.
> 
> Builds fine in Poudriere for 11.1/amd64, 10.4/i386, 12.0/amd64

Firstly; thank you for all the time you put into your patch.

> the current version of uTox 0.11.0 seems to segfault for me.

Funny, this is the first time anyone's said this. It works for me(tm)
on both 11*, and 12. Are you using it on a tier1 platform/arch?

> I'd also like to request maintainership of uTox.

Hmm, uTox has always been my go-to app for all my messaging needs,
which is why I took maintainer(ship). So I'm not sure why I'd be in
any hurry to relinquish Maintainer. :-)

> Updating it to 0.17.0 fixes this.
Indeed, I'm aware of the more recent version, and already have much
of the work finished. But my work on this was preempted by several
other pr(1)'s:
 bug #229159
 bug #229128
 bug #229115
 bug #197035
and a couple others. The above pr's are all ready, and waiting for commit.
Additionally; my work on the uTox up(date|grade) doesn't include:
LLD_UNSAFE=	yes
which is a recent kludge added to introduce the least amount of
disruption to the ports tree after setting llvm ld is ld.

Lastly; uTox 0.17, as seen 2108-06-21 on GitHub, carries a MIT
license
https://github.com/uTox/uTox/blob/v0.17.0/LICENSE
In fact, the commit message indicates their distaste for the previous
(GPL*) license, and they converted it.

Please see alternate proposed patch, as well as a QA log excerpting
proof that it tests/builds in a fresh 12-CURRENT/amd64 jail(8).

Thanks!

--Chris
Comment 5 Chris Hutchinson 2018-06-21 17:53:26 UTC
(In reply to Tobias Kortkamp from comment #3)
> (In reply to Chris Hutchinson from comment #2)
> So it's the same patch except for some changes in the LICENSE block?
> 
> GPLv3 was in there because the developers claim that sections of the code
> might still be GPLv3 licensed.  See
> https://github.com/uTox/uTox/blob/develop/LICENSE.

I encountered a "mid-air-collision" when you posted this.
I'll await your response, Tobias. :-)

Thanks!

--Chris
Comment 6 commit-hook freebsd_committer 2018-06-21 17:54:23 UTC
A commit references this bug:

Author: tobik
Date: Thu Jun 21 17:53:49 UTC 2018
New revision: 472992
URL: https://svnweb.freebsd.org/changeset/ports/472992

Log:
  net-im/uTox: Update to 0.17.0

  - Update license and WWW

  Changes:	https://github.com/uTox/uTox/releases
  PR:		229198
  Submitted by:	tobik
  Approved by:	maintainer

Changes:
  head/net-im/uTox/Makefile
  head/net-im/uTox/distinfo
  head/net-im/uTox/files/patch-CMakeLists.txt
  head/net-im/uTox/files/patch-src_main.h
  head/net-im/uTox/files/patch-src_xlib_main.c
  head/net-im/uTox/files/patch-src_xlib_video.c
  head/net-im/uTox/pkg-descr
  head/net-im/uTox/pkg-plist
Comment 7 Tobias Kortkamp freebsd_committer 2018-06-21 17:56:42 UTC
Committed. Thanks!