Summary: | [patch] devel/fossil: add fossil_proto="https" option to rc-file | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Oleh Hushchenkov <o.hushchenkov> | ||||||
Component: | Individual Port(s) | Assignee: | Pietro Cerutti <gahr> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | o.hushchenkov | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(gahr) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
As far as I understand, the -https switch is used in conjunction with -scgi to overrides the CGI "HTTPS" parameter. With your patch, you can choose either "scgi" or "https" as a fossil_proto, which doesn't make sense to me. How about allowing additional parameters in fossil_args instead? Or a dedicated fossil_https switch, which sets the --https command line option if non empty. Hi Pietro. I use fossil(--https without --scgi) + nginx as reverse proxy with enforced https. Using fossil_args to enforcing https connection is little ugly, but acceptable, solution for me. Dedicated fossil_https switch is much better. In any case, feel free to close this PR. Thanks for you work on this! Created attachment 194463 [details]
Add fossil_https parameter
Hi Oleh, how about this patch? (In reply to Pietro Cerutti from comment #5) > [ -z "${fossil_https}" ] && fossil_args="${fossil_args} --https" Did you mean: "[ -n ..."? Oh, of course :) (In reply to Pietro Cerutti from comment #7) I am completely fine with this patch. Thank you. A commit references this bug: Author: gahr Date: Fri Jun 22 08:06:06 UTC 2018 New revision: 473020 URL: https://svnweb.freebsd.org/changeset/ports/473020 Log: devel/fossil: add fossil_https rc.conf setting When the rc.conf fossil_https is set to a non-empty string, the --https parameter is added to the fossil serve command line to force HTTPS communication. PR: 229200 Submitted by: Oleh Hushchenkov <gor@clogic.com.ua> Changes: head/devel/fossil/Makefile head/devel/fossil/files/fossil.in |
Created attachment 194452 [details] Patch