Bug 229227

I think #!/usr/local/bin/python without version number.

(In reply to w.schwarzenfeld from comment #1)
No, it should be definitely python3, because python2 support was removed in FVWM 2.6.8.

(In reply to ILUXA from comment #2)
Moreover, it is good idea to add py36-xdg as FVWM dependency, because FVWM XDG menu generation won't work without this package installed.

Comment 4 Cy Schubert 2018-06-26 13:54:02 UTC

Created attachment 194648 [details]
Patch

Can you try this?

It is working (adds py36-xdg as fvwm dependency),
but the main problem with /usr/local/bin/fvwm-menu-desktop file
still exists, it uses "#!:" as its interpreter.
Maybe it is possible to change it via "post-install"?

Comment 6 Cy Schubert 2018-06-27 01:24:19 UTC

Something must be unique about your installation.

slippy$ head /usr/local/bin/fvwm-menu-desktop
#!/usr/local/bin/python3
 
# Modification History

# Changed on 18/03/19 by Jaimos Skriletz:
# - Updated script for and require Python 3.
# - Drop support for Python 2.
# - Added support for xdg.Menu.Separator.
# - Added option --term-cmd to state the terminal emulator command
#   to use with Terminal=True .desktop entries. Default: xterm -e
slippy$ 

Can you provide pkg info -aI and pkg info -ao outputs as attachments, please?

After I deleted manually "/usr/local/bin/fvwm-menu-desktop"
and then reinstalled fvwm using your new patch,
interpreter changed to "/usr/local/bin/python3",
so it seems fvwm-menu-desktop will not be reinstalled
if you won't delete in manually,try to move
fvwm2 port with new Makefile to /usr/ports/x11-wm/fvwm2.bak
and then extract current fvwm2 port from ports tree:
# portsnap fetch extract x11-wm/fvwm2
then install it, check that fvwm-menu-desktop interpreter is "#!:"
and after fvwm2.bak port will be reinstalled, fvwm-menu-desktop interpreter
shouldn't be changed and it still should be "#!:"

But even when interpreter is "/usr/local/bin/python3"
the problem still exists, because there is no such file
like "/usr/local/bin/python3" and fvwm-menu-desktop won't work
and keeps saying 
"/usr/local/bin/fvwm-menu-desktop: bad interpreter: /usr/local/bin/python3: no such file or directory"
so interpreter should be python3.6 and not python3,
python3 is in use in GNU/Linux, while FreeBSD python3
executable is python3.6.

Also I tested this on a clean 11.1 virtual machine and I got the same results,
so probably it is not a problem with my installation.

Comment 8 Cy Schubert 2018-06-27 19:14:40 UTC

Can you provide pkg info -aI and pkg info -ao outputs as attachments, please?

Created attachment 194692 [details]
pkg info -aI

Created attachment 194693 [details]
pkg info -ao

Comment 11 commit-hook 2018-06-29 21:36:16 UTC

A commit references this bug:

Author: cy
Date: Fri Jun 29 21:36:00 UTC 2018
New revision: 473582
URL: https://svnweb.freebsd.org/changeset/ports/473582

Log:
  fvwm-menu-desktop-config.fpl fails to detect any python3 unless
  $LOCALBASE/bin/python3 is installed. Address the issue.

  PR:		229227

Changes:
  head/x11-wm/fvwm2/Makefile

Comment 12 Cy Schubert 2018-06-29 22:31:25 UTC

I managed to reproduce the problem. It depends on $LOCALBASE/bin/python3. Dependency added. Fixed.

Yes, now it's working without any issues for me also. Thanks.