Bug 229248
| Summary: | databases/rocksdb: Add RTTI option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andreas Sommer <andreas.sommer87> | ||||
| Component: | Individual Port(s) | Assignee: | Walter Schwarzenfeld <w.schwarzenfeld> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | CC: | lx, w.schwarzenfeld | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Note: I guess this needs a revision bump (not part of my patch). lx@ (maintainer of rocksdb-lite) is Cc'd. rocksdb-lite was added to the ports tree as a dependency of sysutils/osquery. And osquery is the only consumer which requires RTTI. That's why RTTI was only enabled in rocksdb-lite. I'll doublecheck with the devs, but last I checked, rocksdb-lite does still require RTTI (not to build, but because of some subtle bugs). So if you want to commit this soon, let's make it so that it continues to default to on for -lite. Will update if I hear anything different from the devs. I'm not going to commit this. I just explain the reason why RTTI is enabled in rocksdb-lite. I'm fine to keep compatibility for -lite, i.e. .if !defined(LITE) # ... .else OPTIONS_DEFAULT+= RTTI # ... .endif and probably put in a comment for the reason. Anything speaking against committing the new option in this backward-compatible fashion? ping! |
Created attachment 194531 [details] Makefile change to add RTTI option, default off The "full" package did not have the option to enable RTTI support, while the `rocksdb-lite` package had it turned on by default (strange for a "lite" version because it increases size). This patch turns both into an option, defaulting to off. Feel free to adapt if the lite version had an urgent requirement on RTTI for some reason that was not documented in the port.