Bug 229255

Summary: devel/cmake: fails to detect latest devel/libuv (1.21.0)
Product: Ports & Packages Reporter: Charlie Li <vishwin>
Component: Individual Port(s)Assignee: Raphael Kubo da Costa <rakuco>
Status: Closed FIXED    
Severity: Affects Many People CC: kde, tcberner, thierry
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://gitlab.kitware.com/cmake/cmake/merge_requests/2169

Description Charlie Li freebsd_committer 2018-06-23 18:18:10 UTC
After attempting to rebuild devel/cmake upon updating devel/libuv, the following error is emitted during configure:

-- Could NOT find LibUV: Found unsuitable version "", but required is at least "1.10.0" (found /usr/local/lib/libuv.so)
CMake Error at CMakeLists.txt:551 (message):
  CMAKE_USE_SYSTEM_LIBUV is ON but a libuv is not found!
Call Stack (most recent call first):
  CMakeLists.txt:682 (CMAKE_BUILD_UTILITIES)

-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/devel/cmake/work/cmake-3.11.4/CMakeFiles/CMakeOutput.log".
See also "/wrkdirs/usr/ports/devel/cmake/work/cmake-3.11.4/CMakeFiles/CMakeError.log".
Error when bootstrapping CMake:
Problem while running initial CMake

Appears that the latest libuv does not expose its version to cmake like it should.
Comment 1 Raphael Kubo da Costa freebsd_committer 2018-06-23 18:49:11 UTC
I'm working on it, I already sent a fix upstream: https://gitlab.kitware.com/cmake/cmake/merge_requests/2169
Comment 2 commit-hook freebsd_committer 2018-06-23 18:52:33 UTC
A commit references this bug:

Author: rakuco
Date: Sat Jun 23 18:51:48 UTC 2018
New revision: 473149
URL: https://svnweb.freebsd.org/changeset/ports/473149

  Add a patch to unbreak `make configure' with libuv 1.21.0.

  r473142 updated libuv and broke CMake. The new release moved internal headers
  to the uv/ directory, and CMake needs to be taught about it.

  Not bumping PORTREVISION as FindLibUV.cmake is not installed and no builds with
  the new libuv could have worked before.

  PR:		229255

Comment 3 commit-hook freebsd_committer 2018-06-23 20:04:32 UTC
A commit references this bug:

Author: rakuco
Date: Sat Jun 23 20:03:56 UTC 2018
New revision: 473160
URL: https://svnweb.freebsd.org/changeset/ports/473160

  Copy devel/cmake patch from r473149.

  devel/cmake-gui also needs this in order to build after r473142.

  PR:		229255
  Reported by:	tcberner

Comment 4 Thierry Thomas freebsd_committer 2018-06-24 08:07:53 UTC
(In reply to Raphael Kubo da Costa from comment #1)

Thanks Raphael!