Bug 229442

Summary: textproc/xlhtml: Fix build when GNU Autotools are installed.
Product: Ports & Packages Reporter: Yasuhiro Kimura <yasu>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me CC: portmaster
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch file none

Description Yasuhiro Kimura freebsd_committer freebsd_triage 2018-07-01 04:00:39 UTC 
Created attachment 194805 [details]
patch file

Commit message of ports r472723 says it fixes build when GNU Autotools
are installed. In fact, however, this port is still broken as
following.

----------------------------------------------------------------------
yasu@eastasia[2001]% pwd
/usr0/freebsd/ports/head.original/textproc/xlhtml
yasu@eastasia[2002]% svnversion
473648
yasu@eastasia[2003]% pkg info autoconf automake
autoconf-2.69_1
automake-1.16.1
yasu@eastasia[2004]% make PORTSDIR=/usr0/freebsd/ports/head.original build
===>   NOTICE:

The xlhtml port currently does not have a maintainer. As a result, it is
more likely to have unresolved issues, not be up-to-date, or even be removed in
the future. To volunteer to maintain this port, please create an issue at:

https://bugs.freebsd.org/bugzilla

More information about port maintainership is available at:

https://www.freebsd.org/doc/en/articles/contributing/ports-contributing.html#maintain-port

===>  License GPLv2+ accepted by the user
===>   xlhtml-0.5_5,1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by xlhtml-0.5_5,1 for building
===>  Extracting for xlhtml-0.5_5,1
=> SHA256 Checksum OK for xlhtml-0.5.tgz.
===>  Patching for xlhtml-0.5_5,1
===>  Applying FreeBSD patches for xlhtml-0.5_5,1
===>   xlhtml-0.5_5,1 depends on executable: gmake - found
===>  Configuring for xlhtml-0.5_5,1
configure: loading site script /usr0/freebsd/ports/head.original/Templates/config.site
checking build system type... amd64-portbld-freebsd11.2
checking host system type... amd64-portbld-freebsd11.2
checking for a BSD compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking whether gmake sets ${MAKE}... yes
checking for working aclocal... found
checking for working autoconf... found
checking for working automake... found
checking for working autoheader... found
checking for working makeinfo... found
checking for gcc... cc
checking for C compiler default output... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for executable suffix... 
checking for object suffix... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for ranlib... ranlib
checking for strerror in -lcposix... no
checking how to run the C preprocessor... cpp
checking for malloc.h... (cached) no
checking for cc option to accept ANSI C... none needed
checking for an ANSI C-conforming const... yes
checking for ANSI C header files... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for memory.h... (cached) yes
checking for strings.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for unistd.h... (cached) yes
checking for size_t... (cached) yes
checking for unsigned char... (cached) yes
checking size of unsigned char... 1
checking for unsigned short... (cached) yes
checking size of unsigned short... 2
checking for unsigned int... (cached) yes
checking size of unsigned int... 4
checking for unsigned long... (cached) yes
checking size of unsigned long... 8
checking for unsigned long long... (cached) yes
checking size of unsigned long long... 8
checking for float... yes
checking size of float... 4
checking for double... yes
checking size of double... 8
checking for long double... (cached) yes
checking size of long double... 16
checking whether byte ordering is bigendian... no
checking for strip... strip
configure: creating ./config.status
config.status: creating Makefile
config.status: creating cole/Makefile
config.status: creating cole/version.c
config.status: creating cole/cole.h
config.status: creating xlhtml/Makefile
config.status: creating ppthtml/Makefile
config.status: creating config.h
===>  Building for xlhtml-0.5_5,1
gmake[1]: Entering directory '/usr0/freebsd/ports/work/usr0/freebsd/ports/head.original/textproc/xlhtml/work/xlhtml-0.5'
cd . && aclocal
aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
cd . && automake --gnu Makefile
automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
configure.in:16: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated.  For more info, see:
configure.in:16: https://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation
configure.in:19: error: required file './compile' not found
configure.in:19:   'automake --add-missing' can install 'compile'
gmake[1]: *** [Makefile:95: Makefile.in] Error 1
gmake[1]: Leaving directory '/usr0/freebsd/ports/work/usr0/freebsd/ports/head.original/textproc/xlhtml/work/xlhtml-0.5'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr0/freebsd/ports/head.original/textproc/xlhtml
yasu@eastasia[2005]% 
----------------------------------------------------------------------

And attached patch really fix the problem.
Comment 1 Chris Hutchinson 2018-07-02 17:49:25 UTC 
Heh. Your proposed patch looks exactly like the patch I originally proposed in the pr against the most recent commit.
But it was changed, because it was reported that it didn't build in ports-mgmt/poudriere.
Hopefully your patch is accepted, and committed as is. :-)

--Chris
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-07-02 19:30:57 UTC 
A commit references this bug:

Author: swills
Date: Mon Jul  2 19:30:50 UTC 2018
New revision: 473767
URL: https://svnweb.freebsd.org/changeset/ports/473767

Log:
  textproc/xlhtml: Try again to fix build when Autotools are installed

  r472723 seems to have been incomplete

  PR:		229442
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>

Changes:
  head/textproc/xlhtml/Makefile
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-07-02 19:31:59 UTC 
Committed, thanks!