Bug 229550

Summary: src/sys/dev/sound/macio/onyx.c:203: bad if ?
Product: Base System Reporter: David Binderman <dcb314>
Component: kernAssignee: freebsd-multimedia (Nobody) <multimedia>
Status: New ---    
Severity: Affects Only Me    
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   

Description David Binderman 2018-07-05 20:24:27 UTC
src/sys/dev/sound/macio/onyx.c:203]: (style) Expression is always false because 'else if' condition matches previous condition at line 200.

Source code is

       if (strcmp(name, "codec") == 0) {
                if (iicbus_get_addr(dev) != PCM3052_IICADDR)
                        return (ENXIO);
        } else if (strcmp(name, "codec") == 0) {
                compat = ofw_bus_get_compat(dev);
                if (compat == NULL || strcmp(compat, "pcm3052") != 0)
                        return (ENXIO);