Bug 229689

Summary: freebsd-update shouldn't add system breaking comments to config files
Product: Base System Reporter: Dan MacDonald <allcoms>
Component: confAssignee: freebsd-bugs (Nobody) <bugs>
Status: New ---    
Severity: Affects Only Me CC: 0mp, arkr17997
Priority: --- Keywords: needs-qa
Version: 11.2-RELEASE   
Hardware: Any   
OS: Any   

Description Dan MacDonald 2018-07-11 06:49:03 UTC
Yesterday I used freebsd-update to upgrade from 11.1 to 11.2. I probably should've waited until the weekend or a time when I wasn't as tired or in a hurry because it was past my bedtime on a school night and so after it had downloaded all the patches and it was asking me to evaluate the changes in various config files I just said "Yeah whatever" and blindly accepted all of the suggested changes, presuming that freebsd-update or any of the update scripts wouldn't do anything stupid but unfortunately it did make some breaking changes to my config files to prevented me logging in after the upgrade.

I'm unsure of the full extent of the damage but the main ones I'm aware of were a couple of 'uncommented comments' added to /etc/ssh/sshd_config. freebsd-update added these two lines:

<<<<<<< current version
>>>>>>> 11.2-RELEASE

Because there was no hash sign at the beginning of either line, sshd choked on these two lines and I couldn't log into my server via ssh. I then had to spend 30 minutes digging out a VGA cable and hooking up a monitor to fix my ssh config file. Thankfully the server is in my house and wasn't doing anything important at the time but I can see this biting others harder and in a more expensive way. I can guarantee I won't be the only person who blindly accepts the suggested modifications during an upgrade.
Comment 1 Thanos 2018-07-20 11:37:00 UTC