Bug 229711
| Summary: | [UPDATE] games/jaggedalliance2: update to 0.16.1 release | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dima Panov <fluffy> | ||||||
| Component: | Individual Port(s) | Assignee: | Lars Engels <lme> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | lme | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(lme) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thanks for this, I am going to try your patch and commit it. One thing could be wrong: "Set LICENSE to Public Domain" Upstream's ReadMe states: "Unless specified explicitly in the commit message, all changes since commit 8287b98 are released to the public domain. All libraries in dependencies/lib-* have their own licenses. It is not known under which license Tron released his changes. All we know, the source codes were publicly available in his svn repository." (In reply to Lars Engels from comment #1) Bundled libs are always not matters, but original SCI-SCLA may be inherited. LICENSE= PD SCI-SCLA LICENSE_COMB= multi LICENSE_FILE_SCI-SCLA="${WRKDIR}/SFI Source Code license agreement.txt" ? I'm not an expert in the licenses framework, so I rely on you that this is the right way to do this. :) Meanwhile I tested your patch and building worked fine. But the ja2 binary crashes on startup when you don't start it with CWD /usr/local/share/jaggedalliance2 Does it work for you? Maybe we need wrapper script that switches to the directory before calling ja2. (In reply to Lars Engels from comment #3) Sorry for a late answer but yes, seems like some shell hacking is required, main ja2 binary and ja2-launcher should run from ${DATADIR} :( CmakeLists.txt should be adjusted to install launcher as "ja2-launcher.bin", and "ja2-launcher" will be a shell script with CWD to keep original name and shortcuts I've also tested proposed pull request https://github.com/ja2-stracciatella/ja2-stracciatella/pull/672, but without any success :( Created attachment 203439 [details] jaggedalliance2.diff Here's a rebased and cleaned up patch. The port has been marked as broken since November and has now been marked as deprecated so let's fix it. > Meanwhile I tested your patch and building worked fine. But the > ja2 binary crashes on startup when you don't start it with CWD > /usr/local/share/jaggedalliance2 This can be fixed by setting EXTRA_DATA_DIR in the build. Thanks, I'll take a look at your patch! A commit references this bug: Author: lme Date: Tue Apr 9 19:38:53 UTC 2019 New revision: 498512 URL: https://svnweb.freebsd.org/changeset/ports/498512 Log: games/jaggedalliance2: - Update to 0.16.1 - Unbreak and remove expiration date - Fetch from Github - Add LICENSE - Use CMake/Ninja for the main build - Switch to Rust / Cargo to build libstracciatella.so - Pass to new maintainer (tobik). Thanks for taking it! PR: 229711 Submitted by: fluffy, rebased and updated by tobik Changes: head/games/jaggedalliance2/Makefile head/games/jaggedalliance2/distinfo head/games/jaggedalliance2/files/ head/games/jaggedalliance2/pkg-descr head/games/jaggedalliance2/pkg-message head/games/jaggedalliance2/pkg-plist Committed, thanks! |
Created attachment 195064 [details] [UPDATE] games/jaggedalliance2: update to 0.16.1 release [UPDATE] games/jaggedalliance2: - Update game to 0.16.1 release - The project moved to GitHub - Use CMake/Ninja for the main build - Use Cargo/Rust to build libstracciatella.so - Use X11/GL - Use SDL2 - Set LICENSE to Public Domain - Use custom pre-configure and post-build targets due to port infrastructure don't allow mixed CMake/Cargo builds yet