| Summary: | src/lib/libugidfw/ugidfw.c:105: poor error checking ? | ||
|---|---|---|---|
| Product: | Base System | Reporter: | David Binderman <dcb314> |
| Component: | misc | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | New --- | ||
| Severity: | Affects Only Me | ||
| Priority: | --- | ||
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
src/lib/libugidfw/ugidfw.c:105]: (style) Checking if unsigned variable 'len' is less than zero. Source code is len = snprintf(cur, left, "uid %s", pwd->pw_name); if (len < 0 || len > left) but len is unsigned and the return value from snprintf is int. Suggest sanity check return value before assignment into unsigned variable. Multiple duplicates: src/lib/libugidfw/ugidfw.c:112]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:123]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:130]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:137]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:145]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:155]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:162]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:173]: (style) Checking if unsigned variable 'len' is less than zero. [src/lib/libugidfw/ugidfw.c:180]: (style) Checking if unsigned variable 'len' is less than zero. ...