Bug 229873

Summary: New port: deskutils/lookbook, a GTK icon browser
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: ndowens04
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
lookbook.patch none

Description Val Packett 2018-07-18 17:55:16 UTC 
Created attachment 195258 [details]
lookbook.patch

https://github.com/danrabbit/lookbook
Comment 1 Nathan 2018-08-23 16:39:57 UTC 
Looking at the plist file. The binary name should be changed. A user will not want to type in that long name and doesn’t make sense. Rest of the names needs to be fixed in share dir as well.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-24 09:00:21 UTC 
A commit references this bug:

Author: tobik
Date: Fri Aug 24 08:59:54 UTC 2018
New revision: 477948
URL: https://svnweb.freebsd.org/changeset/ports/477948

Log:
  New port: deskutils/lookbook

  LookBook is a GTK based browser for system icons with search and
  code sample functionality.

  WWW: https://github.com/danrabbit/lookbook

  PR:		229873
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/deskutils/Makefile
  head/deskutils/lookbook/
  head/deskutils/lookbook/Makefile
  head/deskutils/lookbook/distinfo
  head/deskutils/lookbook/files/
  head/deskutils/lookbook/files/patch-src_CategoryView.vala
  head/deskutils/lookbook/pkg-descr
  head/deskutils/lookbook/pkg-plist
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-24 09:01:27 UTC 
(In reply to Greg V from comment #0)
Hi,
 
it did not build with the Vala we have in the vanilla ports tree,
so I had to do some trivial patching.

../src/CategoryView.vala:75.24-75.30: error: The name `ACTIONS' does not exist in the context of `CategoryView.icons'
            category = ACTIONS
                       ^^^^^^^
../src/CategoryView.vala:75.13-75.30: error: Invalid type for member `category'
            category = ACTIONS
            ^^^^^^^^^^^^^^^^^^

https://github.com/danrabbit/lookbook/issues/33

(In reply to Nathan from comment #1)

> Looking at the plist file.  The binary name should be changed.  A
> user will not want to type in that long name and doesn’t make sense.

I disagree.  The name should stay as is.  It's how upstream names
the binary and we should too.

LookBook appears just fine in the user's app menu/launcher.