Bug 229898
| Summary: | [exp-run] lang/ruby2[45]: get rid of unescaped "-Wl,soname,$@" in LDFLAGS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dima Panov <fluffy> | ||||
| Component: | Individual Port(s) | Assignee: | Dima Panov <fluffy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | albert.shih, romain | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ruby) koobs: merge-quarterly+ antoine: exp-run+ |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://reviews.freebsd.org/D16341 | ||||||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230238 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231361 |
||||||
| Attachments: |
|
||||||
devel/ruby-sdl fails to build: http://pb2.nyi.freebsd.org/data/111i386-default-PR229898/2018-07-20_14h19m59s/logs/errors/ruby24-sdl-2.1.3.1_4.log (In reply to Antoine Brodin from comment #1) Should be fixed by r475063 Exp-run looks fine. A commit references this bug: Author: fluffy Date: Sat Jul 28 02:53:06 UTC 2018 New revision: 475483 URL: https://svnweb.freebsd.org/changeset/ports/475483 Log: lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped macro '$@' in the pkg-config template lang/ruby23 is already fixed same way, port it to newer releases By the way, this unbreak ninja builds with any port relied on libruby.so PR: 229898 Submitted by: fluffy Reviewed by: ruby (miwi) Approved by: ruby (miwi) Exp-run by: antoine MFH: 2018Q3 Differential Revision: D16341 Changes: head/Mk/bsd.ruby.mk head/lang/ruby24/files/patch-configure.in head/lang/ruby25/files/patch-configure.ac A commit references this bug: Author: fluffy Date: Sat Jul 28 03:37:54 UTC 2018 New revision: 475488 URL: https://svnweb.freebsd.org/changeset/ports/475488 Log: MFH: r475483 lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped macro '$@' in the pkg-config template lang/ruby23 is already fixed same way, port it to newer releases By the way, this unbreak ninja builds with any port relied on libruby.so PR: 229898 Submitted by: fluffy Reviewed by: ruby (miwi) Approved by: ruby (miwi) Exp-run by: antoine Differential Revision: D16341 Approved by: ports-secteam (miwi) Changes: _U branches/2018Q3/ branches/2018Q3/Mk/bsd.ruby.mk branches/2018Q3/lang/ruby24/files/patch-configure.in branches/2018Q3/lang/ruby25/files/patch-configure.ac This change breaks sysutils/facter (build fine, but does not run; see bug 230238 for details). Do you have an idea about what is going wrong? (In reply to Romain Tartière from comment #6) Sorry for late answer but yes, I have some ideas after fast check. Will investigate more next days. (In reply to Dima Panov from comment #7) Any new about this problem with facter/puppet/ruby ? It's become a annoying for those who use puppet for everything. Regards (In reply to albert.shih from comment #8) Resolved in ports r480158 by romain@ in bug 230238 |
Created attachment 195287 [details] lang/ruby2[45]: get rid of unescaped "-Wl,soname,$@" in LDFLAGS lang/ruby2[45]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped macro '$@' for build and in the pkg-config template lang/ruby23 is already fixed same way, port it to newer releases This unbreak ninja builds with any ports relied on libruby.so === example buildlog unpatched === ninja: error: build.ninja:3434: bad $-escape (literal $ must be written as $$) LINK_LIBRARIES = -fstack-protector -Wl,-soname,$@ -lruby24 -lelf -lunw... ^ near here ==================================