Bug 230020

Summary: [PATCH] chinese/pcmanx: Fix the code that incorrectly trim URL.
Product: Ports & Packages Reporter: holishing <holishingtest>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Some People CC: holishingtest, lantw44, lwhsu
Priority: --- Keywords: patch
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
patched for this port.
none
note that there is a port revision
none
correct the place of revision words
none
merged patches for this port.
none
merged patches for this port. none

Description holishing 2018-07-24 17:12:37 UTC 
Created attachment 195427 [details]
patched for this port.

It is bug fix patch from upstream(master branch):
https://github.com/pcman-bbs/pcmanx/pull/69

but there is no any release plan (for e.g. PCManX v1.4) in upstream team.
even though this is an apparent problem.

and fix a compilation error effected in clang v6.0.x .
Comment 1 holishing 2018-07-24 17:14:05 UTC 
Created attachment 195428 [details]
note that there is a port revision
Comment 2 holishing 2018-07-24 17:16:48 UTC 
Created attachment 195429 [details]
correct the place of revision words
Comment 3 holishing 2018-07-26 00:53:08 UTC 
Created attachment 195459 [details]
merged patches for this port.

merged 2 files into single patch for more convenient to test it.
Comment 4 holishing 2018-07-26 00:55:57 UTC 
Created attachment 195460 [details]
merged patches for this port.

merged patches for this port.

merged 2 files into single patch for more convenient to test it.

(correct details)
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-11 08:31:44 UTC 
A commit references this bug:

Author: lwhsu
Date: Sat Aug 11 08:30:56 UTC 2018
New revision: 476861
URL: https://svnweb.freebsd.org/changeset/ports/476861

Log:
  - Added a patch in upstream but not release yet to fix the code that
    incorrectly trim URL [1]
  - Sort patches
  - Pet portlint

  PR:		230020 [1]
  Submitted by:	holishing <holishingtest@gmail.com>

Changes:
  head/chinese/pcmanx/Makefile
  head/chinese/pcmanx/files/patch-configure
  head/chinese/pcmanx/files/patch-src-mainframe.cpp
  head/chinese/pcmanx/files/patch-src-pcmanx_gtk2.cpp
  head/chinese/pcmanx/files/patch-src-view-telnetcon.cpp