Bug 230047
| Summary: | security/softether: use https in MASTER_SITES and WWW | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Koichiro Iwao <meta> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Koichiro Iwao <meta> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | hrs, mat, meta, pi | ||||||||||
| Priority: | --- | Flags: | pi:
maintainer-feedback-
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://reviews.freebsd.org/D16578 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 195463 [details]
patch
Also pet portlint fatal errors and warnings.
- Use tab after =
- Sort ONLY_FOR_ARCHS
- Bring ONLY_FOR_ARCHS earlier
Switched to Phabricator because mat@ point outs lots of existing Makefile issues. https://reviews.freebsd.org/D16578 Maintainer timeout however maintainer is a mentor. ping If responding mat@'s pointing outs takes If responding mat@'s pointing outs takes time, I'll reset the diff and just change the MASTER_SITES and WWW again. I really just wanted to use https instead of http but mat complains lots of other thing :( Created attachment 196623 [details]
patch
Anyway, please please let me just switch to https. s/http/https/ is definitely the easiest change to review. Regarding softether website, https is 100% compatible with http, definitely no side effects, no regression.
I'm really tired receiving complains about Makefile which I'm NOT A MAINTAINER!!
mat@, talk to the maintainer, not me.
Created attachment 196624 [details]
patch
attached wrong patch, this is the correct one.
(In reply to Koichiro Iwao from comment #7) > Created attachment 196623 [details] > patch > > Anyway, please please let me just switch to https. s/http/https/ is > definitely the easiest change to review. Regarding softether website, https > is 100% compatible with http, definitely no side effects, no regression. > > I'm really tired receiving complains about Makefile which I'm NOT A > MAINTAINER!! > > mat@, talk to the maintainer, not me. You are a committer, and you submitted the patch. It is your responsibility to see it through. You already have the maintainer timeout, so you can commit the patch, along with the fixes I pointed out. I do not understand where this aggressiveness is coming from. A commit references this bug: Author: meta Date: Wed Oct 31 15:03:20 UTC 2018 New revision: 483589 URL: https://svnweb.freebsd.org/changeset/ports/483589 Log: Take maintainership due to long inactivity on these ports. PR: 232372 230047 230050 Approved by: maintainer timeout, mentors (implicit) Changes: head/security/softether/Makefile head/security/softether-devel/Makefile Grab. Before everything, I switch MASTER_SITES and WWW to HTTPS. A commit references this bug: Author: meta Date: Wed Oct 31 15:21:46 UTC 2018 New revision: 483592 URL: https://svnweb.freebsd.org/changeset/ports/483592 Log: secutiry/softether: use https in MASTER_SITES and WWW Upstream provides https site since a very long time ago. PR: 230047 Approved by: mentors (implicit) Changes: head/security/softether/Makefile head/security/softether/pkg-descr Committed https change. It is the main topic of this PR and 100% no regression, almost nothing to test. So it can be committed carelessly. The rest issues will be done in phabricator: https://reviews.freebsd.org/D16578 |
Created attachment 195461 [details] patch Upstream now provides https site.