Bug 230079
| Summary: | math/aspcud: Update to 1.9.4 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
| Component: | Individual Port(s) | Assignee: | Vsevolod Stakhov <vsevolod> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(vsevolod) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Could you please explain why have you changed PORTVERSION to DISTVERSION? (In reply to Vsevolod Stakhov from comment #1) DISTVERSION is the version set by distfile. PORTVERSION is the version of the port/package. In this case, the version is defined by the distfile, therefore this is DISTVERSION. In general, they are different, in this case they happen to be the same. Regards, Yuri I'm asking because the general policy is to prefer PORTVERSION over DISTVERSION: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html (In reply to Vsevolod Stakhov from comment #3) Vsevolod, I scanned through this chapter and couldn't find where does it say that PORTVERSION is preferred. Could you please cite the wording which says this?
Well, I couldn't really find any sane definition of the preferred order: "Some vendor's distribution names which do not fit into the ${PORTNAME}-${PORTVERSION}-scheme can be handled automatically by setting DISTVERSIONPREFIX, DISTVERSION, and DISTVERSIONSUFFIX. PORTVERSION will be derived from DISTVERSION automatically." However, "If the upstream version scheme can be derived into a ports-compatible version scheme, set some variable to the upstream version, do not use DISTVERSION as the variable name. Set PORTVERSION to the computed version based on the variable you created, and set DISTNAME accordingly." Now I'm inclined to think that I was either wrong assuming that or there is some rule of thumb. I will check more later.
A commit references this bug: Author: vsevolod Date: Wed Aug 8 11:05:53 UTC 2018 New revision: 476636 URL: https://svnweb.freebsd.org/changeset/ports/476636 Log: Update to 1.9.4 PR: 230079 Submitted by: yuri Changes: head/math/aspcud/Makefile head/math/aspcud/distinfo head/math/aspcud/pkg-descr Committed, thank you! PORTVERSION->DISTVERSION change is not accepted, I've kept PORTVERSION here. |
Created attachment 195498 [details] patch