Bug 230205
| Summary: | devel/lua-bitop: fix for 5.3+ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew "RhodiumToad" Gierth <andrew> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Committed. Thanks! A commit references this bug: Author: sunpoet Date: Wed Aug 15 19:34:19 UTC 2018 New revision: 477276 URL: https://svnweb.freebsd.org/changeset/ports/477276 Log: Fix CFLAGS and test - Bump PORTREVISION for package change PR: 230205 Submitted by: Andrew Gierth <andrew@tao11.riddles.org.uk> Changes: head/devel/lua-bitop/Makefile head/devel/lua-bitop/files/ head/devel/lua-bitop/files/extra-patch-bittest.lua |
Created attachment 195662 [details] Patch Makefile contains incorrect -D option that compiles with 5.3, but causes incorrect runtime results. This patch does two things: firstly it provides the correct option without causing warnings on 5.1/5.2 builds, and secondly it conditionally patches the distributed test scripts to compensate for different string conversions in 5.3. As a result, make test should now pass on all lua versions (tested 5.1-5.4)