Summary: | Mk/Uses/perl5.mk: Check existence of directory before "find" command usage for this directory | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||
Component: | Ports Framework | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | mat, perl, ports-bugs, takefu, vd, x11 | ||||
Priority: | --- | Keywords: | patch | ||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
lightside
2018-08-02 06:15:58 UTC
Not related: I didn't find "Ports Framework" component, when submitting bug report to "Ports & Packages". But was able to change it after submit. Sorry about possible not related CC (or it was automatic, except mat@ and perl@). I've had this review opened for a while https://reviews.freebsd.org/D16440 because someone reported this a week ago, they never told me if it fixed the problem. If it does, please do tell and I'll commit it. (In reply to comment #2) > I've had this review opened for a while https://reviews.freebsd.org/D16440 > because someone reported this a week ago, they never told me if it fixed > the problem. Looks like, we proposed identical patches, while you did it about a week ago. I didn't check FreeBSD differential revisions for this issue before this PR. Thanks for noticing about this. (In reply to comment #2) > If it does, please do tell and I'll commit it. If apply patch, then in case of mentioned ports (ftp/wget, x11-servers/xorg-server, etc.), it doesn't report message about "find: <..>/work/stage/usr/local/lib/perl5/site_perl: No such file or directory". Comment on attachment 195755 [details] Proposed patch (since 473539 revision) Obsoleted patch, because of duplicate of review D16440. A commit references this bug: Author: mat Date: Thu Aug 2 08:35:11 UTC 2018 New revision: 476224 URL: https://svnweb.freebsd.org/changeset/ports/476224 Log: Fix spurious errors. PR: 230287 Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D16440 Changes: head/Mk/Uses/perl5.mk A commit references this bug: Author: mat Date: Thu Aug 2 08:38:38 UTC 2018 New revision: 476225 URL: https://svnweb.freebsd.org/changeset/ports/476225 Log: MFH: r476224 Fix spurious errors. PR: 230287 Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D16440 Changes: _U branches/2018Q3/ branches/2018Q3/Mk/Uses/perl5.mk |