Bug 230311
| Summary: | sysutils/wait_on - created a new repository on Github | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Josmar Calin De Pierri <jcpierri> | ||||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | riggs, yuri | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
portlint is not very happy with this patch. Could you take a look and ensure it passes portlint -ac? Created attachment 195901 [details]
Now it passes portlint and port test
I made a new Makefile.
Now the patch passes portlint -ac and port test /usr/ports/sysutils/wait_on
Sorry for making you spend time before it was properly tested.
Hi Josmar, Your version isn't right. GH_TAGNAME=16ff3bc shouldn't be set when the project has a defined version. Please use 'git describe --tags' to find the fully qualifies git version. Please see an example in science/chrono/Makefile. Regards, Yuri Created attachment 196408 [details]
Now it has no GH_TAGNAME and still passes portlint -ac
Thanks for your review Yuri.
I removed the GH_TAGNAME and replaced it with the proper version tag (likewise the example you mention)
A commit references this bug: Author: yuri Date: Tue Aug 21 04:28:28 UTC 2018 New revision: 477700 URL: https://svnweb.freebsd.org/changeset/ports/477700 Log: sysutils/wait_on: Update 1.1 -> 1.1-2 jcpierri@gmail.com takes maintainership Port changes: * Code moved from the original CVS repository to the maintainer's repository on github * Update COMMENT * Add WWW PR: 230311 Submitted by: Josmar <jcpierri@gmail.com> Changes: head/sysutils/wait_on/Makefile head/sysutils/wait_on/distinfo head/sysutils/wait_on/pkg-descr Committed with small changes. Thank you for taking maintainership! |
Created attachment 195787 [details] add a new repository and change mantainer updates sysutils/wait_on - change to a new repository on Github