Bug 230350

Summary:	newsyslog does not distinguish between flags T and P
Product:	Base System	Reporter:	Nicolas Rachinsky <fbsd-bugzilla>
Component:	bin	Assignee:	Mark Johnston <markj>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	fbsd-bugzilla, markj
Priority:	---
Version:	11.2-RELEASE
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259194

Description Nicolas Rachinsky 2018-08-04 13:46:02 UTC

The newsyslog.conf-flags T and P have the same effect, both enable both "Do not compress zero'th history file" and  "Use RFC5424 format rotation message".

The constants used for both flags in /usr/src/usr.sbin/newsyslog/newsyslog.c are the same:

#define CE_PLAIN0       0x0800  /* Do not compress zero'th history file */
#define CE_RFC5424      0x0800  /* Use RFC5424 format rotation message */

Comment 1 commit-hook freebsd_committer

2018-08-04 15:31:35 UTC

A commit references this bug:

Author: markj
Date: Sat Aug  4 15:30:56 UTC 2018
New revision: 337323
URL: https://svnweb.freebsd.org/changeset/base/337323

Log:
  Fix a flag collision introduced in r327451.

  PR:		230350
  MFC after:	3 days

Changes:
  head/usr.sbin/newsyslog/newsyslog.c

Comment 2 commit-hook freebsd_committer

2018-08-07 14:10:22 UTC

A commit references this bug:

Author: markj
Date: Tue Aug  7 14:09:30 UTC 2018
New revision: 337417
URL: https://svnweb.freebsd.org/changeset/base/337417

Log:
  MFC r337323:
  Fix a flag collision introduced in r327451.

  PR:	230350

Changes:
_U  stable/11/
  stable/11/usr.sbin/newsyslog/newsyslog.c