Bug 230354

Summary: emulators/libdsk: Update to 1.4.2
Product: Ports & Packages Reporter: Nathan <ndowens04>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: pixel, tobik
Priority: --- Flags: bugzilla: maintainer-feedback? (pixel)
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://www.seasip.info/Unix/LibDsk/#changelog
Attachments:
Description Flags
Update
none
Poudriere Log 10.4-Release
none
Poudriere Log 11.2-Stable
none
Update
none
Update none

Description Nathan 2018-08-04 15:59:46 UTC 
Created attachment 195847 [details]
Update

Changelog: http://www.seasip.info/Unix/LibDsk/#changelog

WWW: Changed (updated)

Portlint AC: Complains about plist_files+= in .if; Other than that, OK
Comment 1 Nathan 2018-08-04 16:00:26 UTC 
Created attachment 195848 [details]
Poudriere Log 10.4-Release
Comment 2 Nathan 2018-08-04 16:00:56 UTC 
Created attachment 195849 [details]
Poudriere Log 11.2-Stable
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-04 22:29:09 UTC 
Comment on attachment 195847 [details]
Update

+.for i in ${DOCS}
+		${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
+.endfor

More readable and better since it runs ${INSTALL_DATA} only once:

cd ${WRKSRC}/doc && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR}

+DOCS=		apridisk.html cfi.html libdsk.lyx libdsk.pdf \
+		libdsk.txt libdskrc.sample protocol.txt README TODO

Just use PORTDOCS here instead and remove the PLIST_FILES bit below
again.

+.if ${PORT_OPTIONS:MDOCS}
+PLIST_FILES+=	${PORTDOCS}${DOCSDIR}/README ${PORTDOCS}${DOCSDIR}/TODO \
+		${PORTDOCS}${DOCSDIR}/apridisk.html ${PORTDOCS}${DOCSDIR}/cfi.html \
+		${PORTDOCS}${DOCSDIR}/libdsk.lyx ${PORTDOCS}${DOCSDIR}/libdsk.pdf \
+		${PORTDOCS}${DOCSDIR}/libdsk.txt ${PORTDOCS}${DOCSDIR}/libdskrc.sample \
+		${PORTDOCS}${DOCSDIR}/protocol.txt
+.endif

This is not necessary when using PORTDOCS, but you should read up
on options helpers variables either way [1].

Variables should always be set before any targets [2].

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-variables
[2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
Comment 4 Nathan 2018-08-04 22:49:30 UTC 
Created attachment 195869 [details]
Update

Didn't realize PORTDOCS would automaticly add to pkg-plist
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-04 23:14:09 UTC 
(In reply to Nathan from comment #4)
LGTM, thanks.  .include <bsd.port.options.mk> can be removed now too.
Comment 6 Nathan 2018-08-04 23:19:03 UTC 
Created attachment 195870 [details]
Update
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-24 09:15:37 UTC 
A commit references this bug:

Author: tobik
Date: Fri Aug 24 09:14:42 UTC 2018
New revision: 477950
URL: https://svnweb.freebsd.org/changeset/ports/477950

Log:
  emulators/libdsk: Update to 1.4.2

  - Install additional documentation

  Changes:	http://www.seasip.info/Unix/LibDsk/#changelog
  PR:		230354
  Submitted by:	Nathan <ndowens@yahoo.com>
  Approved by:	pixel@hugbox.org (maintainer timeout, 2 weeks)

Changes:
  head/emulators/libdsk/Makefile
  head/emulators/libdsk/distinfo
  head/emulators/libdsk/pkg-descr
  head/emulators/libdsk/pkg-plist