Bug 230356

Summary: [PATCH] games/freeorion: fails to link with lld as system linker
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Some People CC: madpilot
Priority: --- Keywords: patch
Version: LatestFlags: amdmi3: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch adding LLD_UNSAFE none

Description Guido Falsi freebsd_committer freebsd_triage 2018-08-04 17:18:42 UTC 
Created attachment 195850 [details]
patch adding LLD_UNSAFE

On head, where lld is the default compiler freeorion fails with the following error (trimmed):

/usr/bin/ld: error: cannot preempt symbol: alcGetCurrentContext
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

/usr/bin/ld: error: cannot preempt symbol: alSourceStop
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

/usr/bin/ld: error: cannot preempt symbol: alSourcei
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

[...]

Attached patch marks it as unsafe with LLD, forcing usage of old ld for this port. This allows it to link correctly.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2018-08-28 15:39:48 UTC 
Feel free to commit as long as it fixes the problem. It even falls under the blanket IMO.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-29 18:46:13 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Aug 29 18:45:45 UTC 2018
New revision: 478365
URL: https://svnweb.freebsd.org/changeset/ports/478365

Log:
  Mark as LLD_UNSAFE.

  PR:		230356
  Submitted by:	me
  Approved by:	amdmi3 (maintainer)

Changes:
  head/games/freeorion/Makefile
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2018-08-29 18:46:51 UTC 
Committed.

Thanks!