Bug 230362

Summary: net/csocks: Update to 1.7
Product: Ports & Packages Reporter: Nathan <ndowens04>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: raffaele.delorenzo, tobik
Priority: --- Flags: bugzilla: maintainer-feedback? (raffaele.delorenzo)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update
none
Poudriere Log 10.4-Release
none
Update
none
Update
none
Poudriere Log 11.2-Stable
none
Update none

Description Nathan 2018-08-04 20:13:05 UTC 
Created attachment 195856 [details]
Update

Changes:
3 July 2013 Version 1.7:
  - Solved bug in UPDv6 management. Protocol was not set properly.

10 May 2011 Version 1.6:
	- Optimize Hash Table rules
	- Added IPv6 Compatibility on new Linux Header.

Portlint OK
Comment 1 Nathan 2018-08-04 20:14:19 UTC 
Created attachment 195857 [details]
Poudriere Log 10.4-Release
Comment 2 Nathan 2018-08-04 20:24:21 UTC 
Created attachment 195858 [details]
Update
Comment 3 Nathan 2018-08-04 20:28:56 UTC 
Created attachment 195859 [details]
Update
Comment 4 Nathan 2018-08-04 22:08:57 UTC 
Created attachment 195860 [details]
Poudriere Log 11.2-Stable
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-04 22:26:28 UTC 
Comment on attachment 195859 [details]
Update

+USES=		compiler:gcc-c++11-lib

Does it not build with Clang anymore?  Why does it require GCC now?
Forcing GCC usage in a port should be a last resort.

-	${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib
-	${LN} -s libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so
+	${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so.1
+	${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so

This is a bogus change.  You're now installing libcsocks.so.1 twice
(so the package will take twice the space).  libcsocks.so should be a symlink.
Please revert this.

--- net/csocks/files/patch-csocks.c	(nonexistent)
+++ net/csocks/files/patch-csocks.c	(working copy)

net/csocks/files/patch-csocks.c looks fishy.  Why is it needed and why
does it remove a bunch of NULL checks?
Comment 6 Nathan 2018-08-04 22:38:31 UTC 
Created attachment 195868 [details]
Update

Compiler was warning, during manual build as I was messing with it, that NULL pointers was always zero, like it wasn't needed; but anyway reverted what was requested
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-18 12:06:22 UTC 
A commit references this bug:

Author: tobik
Date: Sat Aug 18 12:05:40 UTC 2018
New revision: 477498
URL: https://svnweb.freebsd.org/changeset/ports/477498

Log:
  net/csocks: Update to 1.7

  - Add LICENSE

  PR:		230362
  Submitted by:	Nathan <ndowens@yahoo.com> (based on)
  Approved by:	maintainer timeout (2 weeks)

Changes:
  head/net/csocks/Makefile
  head/net/csocks/distinfo
  head/net/csocks/files/patch-Makefile
  head/net/csocks/pkg-descr
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-18 12:06:47 UTC 
Committed with some changes. Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-08-18 12:10:28 UTC 
A commit references this bug:

Author: tobik
Date: Sat Aug 18 12:10:13 UTC 2018
New revision: 477499
URL: https://svnweb.freebsd.org/changeset/ports/477499

Log:
  net/csocks: Remove bits that probably shouldn't be there

  PR:		230362

Changes:
  head/net/csocks/Makefile
  head/net/csocks/files/patch-Makefile