Bug 230393

Summary: security/base-audit: Use anticongestion function if available
Product: Ports & Packages Reporter: Yasuhiro Kimura <yasu>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: 000.fbsd, pi
Priority: --- Flags: pi: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch file
none
modified patch, bumped version to 0.3 none

Description Yasuhiro Kimura freebsd_committer freebsd_triage 2018-08-05 20:20:04 UTC 
Created attachment 195915 [details]
patch file

* Use anticongestion function if available. Commit message of base r316342 says as following.
  ----------------------------------------------------------------------
  Consolidate random sleeps in periodic scripts

  Multiple periodic scripts sleep for a random amount of time in order to
  mitigate the thundering herd problem. This is bad, because the sum of
  multiple uniformly distributed random variables approaches a normal
  distribution, so the problem isn't mitigated as effectively as it would be
  with a single sleep.
    
  This change creates a single configurable anticongestion sleep. periodic
  will only sleep if at least one script requires it, and it will never sleep
  more than once per invocation. It also won't sleep if periodic was run
  interactively, fixing an unrelated longstanding bug.
  ----------------------------------------------------------------------
* Bump PORTREVISION.
Comment 1 Miroslav Lachman 2018-08-13 09:15:39 UTC 
(In reply to Yasuhiro KIMURA from comment #0)
Htank you for your report. I'll take it in next few days and will release new version of security/base-audit with your anticongestion fix.
Comment 2 Miroslav Lachman 2018-08-17 16:32:23 UTC 
Created attachment 196291 [details]
modified patch, bumped version to 0.3
Comment 3 Miroslav Lachman 2018-08-17 16:34:42 UTC 
I published modified version on my github. This can be committed.
Thank you Yasuhiro.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-09-03 05:23:30 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-09-03 05:23:58 UTC 
A commit references this bug:

Author: pi
Date: Mon Sep  3 05:23:22 UTC 2018
New revision: 478844
URL: https://svnweb.freebsd.org/changeset/ports/478844

Log:
  security/base-audit: update 0.2 -> 0.3

  - Use anticongestion function if available

  PR:		230393
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>
  Approved by:	Miroslav Lachman <000.fbsd@quip.cz> (maintainer)

Changes:
  head/security/base-audit/Makefile
  head/security/base-audit/files/405.pkg-base-audit.in