Bug 230600

Summary: java/openjfx8-devel: fails to build with libc++ 7
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-patch
Priority: --- Flags: bugzilla: maintainer-feedback? (tobik)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230464
Bug Depends on:    
Bug Blocks: 230355    

Description Jan Beich freebsd_committer freebsd_triage 2018-08-13 21:03:49 UTC
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 java/openjfx8-devel
[...]
In file included from modules/web/src/main/native/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28:
In file included from modules/web/src/main/native/Source/JavaScriptCore/bytecode/ArrayProfile.h:29:
In file included from modules/web/src/main/native/Source/JavaScriptCore/runtime/Structure.h:28:
In file included from modules/web/src/main/native/Source/JavaScriptCore/runtime/ClassInfo.h:25:
In file included from modules/web/src/main/native/Source/JavaScriptCore/interpreter/CallFrame.h:30:
In file included from modules/web/src/main/native/Source/JavaScriptCore/runtime/VM.h:38:
In file included from modules/web/src/main/native/Source/JavaScriptCore/runtime/FunctionHasExecutedCache.h:28:
In file included from /usr/include/c++/v1/unordered_map:385:
In file included from /usr/include/c++/v1/__node_handle:16:
/usr/include/c++/v1/optional:171:29: error: redefinition of 'bad_optional_access'
class _LIBCPP_EXCEPTION_ABI bad_optional_access
                            ^
modules/web/src/main/native/Source/WTF/wtf/Optional.h:299:7: note: previous definition is here
class bad_optional_access : public std::logic_error {
      ^

http://package18.nyi.freebsd.org/data/headamd64PR230355-default/2018-08-11_19h01m06s/logs/errors/openjfx8-devel-8.u172.b11_2,1.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-08-13 21:04:22 UTC
Regressed by https://reviews.llvm.org/rL338472 likely due to #include <optional>
Comment 2 Jan Beich freebsd_committer freebsd_triage 2018-08-13 21:07:05 UTC
If you have extra time maybe help fix bug 230464 as well. gnome@ is... understaffed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-08-22 19:38:24 UTC
A commit references this bug:

Author: jbeich
Date: Wed Aug 22 19:38:09 UTC 2018
New revision: 477812
URL: https://svnweb.freebsd.org/changeset/ports/477812

Log:
  www/webkit2-gtk3, java/openjfx8-devel: unbreak with libc++ 7

  In file included from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28:
  In file included from Source/JavaScriptCore/bytecode/ArrayProfile.h:29:
  In file included from Source/JavaScriptCore/runtime/Structure.h:28:
  In file included from Source/JavaScriptCore/runtime/ClassInfo.h:25:
  In file included from Source/JavaScriptCore/interpreter/CallFrame.h:30:
  In file included from Source/JavaScriptCore/runtime/VM.h:40:
  In file included from Source/JavaScriptCore/runtime/FunctionHasExecutedCache.h:28:
  In file included from /usr/include/c++/v1/unordered_map:385:
  In file included from /usr/include/c++/v1/__node_handle:16:
  /usr/include/c++/v1/optional:171:29: error: redefinition of 'bad_optional_access'
  class _LIBCPP_EXCEPTION_ABI bad_optional_access
                              ^
  DerivedSources/ForwardingHeaders/wtf/Optional.h:295:7: note: previous definition is here
  class bad_optional_access : public std::logic_error {
        ^

  PR:		230464 230600
  Submitted by:	dim

Changes:
  head/java/openjfx8-devel/files/patch-modules_web_src_main_native_Source_WTF_wtf_Optional.h
  head/www/webkit2-gtk3/files/patch-Source_WTF_wtf_Optional.h