Summary: | devel/libzim: fails to build with Clang 7 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> |
Component: | Individual Port(s) | Assignee: | Steve Wills <swills> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | Keywords: | needs-patch |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(swills) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
Bug Depends on: | |||
Bug Blocks: | 230355 |
Description
Jan Beich
2018-08-14 19:50:24 UTC
-Werror shouldn't be enabled outside of maintainer mode for unimportant warnings (e.g., -Wall) as it tends to break build on each compiler upgrade/change/etc. If you really care about every warning report upstream after confirming it affects development version. -Wall + -Werror also breaks platforms stuck on GCC (powerpc*, mips*, sparc64). ../src/fileimpl.cpp: In constructor 'zim::FileImpl::FileImpl(const string&)': ../src/fileimpl.cpp:74:33: error: catching polymorphic type 'class zim::ZimFileFormatError' by value [-Werror=catch-value=] } catch (ZimFileFormatError e) { ^ ../src/fileimpl.cpp: In member function 'std::shared_ptr<const zim::Dirent> zim::FileImpl::getDirent(zim::article_index_t)': ../src/fileimpl.cpp:301:18: error: catching polymorphic type 'class zim::InvalidSize' by value [-Werror=catch-value=] } catch (InvalidSize) { ^~~~~~~~~~~ ../src/fileimpl.cpp: In member function 'std::__cxx11::string zim::FileImpl::getChecksum()': ../src/fileimpl.cpp:496:14: error: catching polymorphic type 'class zim::BufferError' by value [-Werror=catch-value=] } catch (BufferError) ^~~~~~~~~~~ cc1plus: all warnings being treated as errors A commit references this bug: Author: swills Date: Wed Aug 15 17:02:12 UTC 2018 New revision: 477240 URL: https://svnweb.freebsd.org/changeset/ports/477240 Log: devel/libzim: Remove -Werror from the build flags Fixes build with Clang 7 PR: 230626 Changes: head/devel/libzim/files/patch-meson.build |