Bug 230692
| Summary: | [exp-run] change USE_GL to USES | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Niclas Zeising <zeising> | ||||
| Component: | Ports Framework | Assignee: | Niclas Zeising <zeising> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | ports-bugs | ||||
| Priority: | --- | Flags: | zeising:
exp-run?
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://reviews.freebsd.org/D16774 | ||||||
| Attachments: |
|
||||||
Could you please put the patch in a code review to ease the review process? Hi! Here's the phab review: https://reviews.freebsd.org/D16774 The patch has been updated in phabricator, based on comments there. Patch updated in phabricator. Patch updated in phabricator Some new failure: http://package23.nyi.freebsd.org/data/111i386-default-PR230692PR230909/2018-08-29_18h58m56s/logs/errors/q3cellshading-1.0_3.log USES must happen before bsd.port.pre.mk inclusion. Patch updated in phabricator with fix for the build failure. Everything in the phab review is taken care of. What is missing to get approval for this? Looks fine, don't forget to fix the remaining ports. A commit references this bug: Author: zeising Date: Mon Sep 10 19:56:33 UTC 2018 New revision: 479445 URL: https://svnweb.freebsd.org/changeset/ports/479445 Log: Change USE_GL to become USES=gl. Change USE_GL to become USES=gl. You still need to specify USE_GL as well, to specify which gl components you need, such as egl glesv2 glut glu glw gl. Only specifying USE_GL is supported for now, to ease in transition. It is however deprecated, and will be removed eventually. Specifying USES=gl without USE_GL is an error. USE_GL=yes is also deprecated, but supported for now. It implies USE_GL=glu. Fix fallout from this change. PR: 230692 Approved by: portmgr (antoine) exp-run by: antoine Reviewed by: mat Differential Revision: https://reviews.freebsd.org/D16774 Changes: head/Mk/Uses/gl.mk head/Mk/bsd.port.mk head/games/q3cellshading/Makefile Committed, closing. It seems that this broke games/xpilot-ng-client A commit references this bug: Author: zeising Date: Sat Sep 22 12:49:02 UTC 2018 New revision: 480381 URL: https://svnweb.freebsd.org/changeset/ports/480381 Log: Fix build after switch to USES=gl Fix build by using USES=gl properly, instead of USE_GL=yes. The latter caused issues on the slave port. PR: 230692 Reported by: antoine Changes: head/games/xpilot-ng-client/Makefile head/games/xpilot-ng-server/Makefile Should be fixed now. |
Created attachment 196278 [details] switch to USES=gl, rev 1 Attached patch adds Mk/Uses/gl.mk, instead of having the code in bsd.ports.mk. This is designed such that you need USES=gl, and then specify components as needed with USE_GL= as before. For backwards compatibility, USE_GL= automatically sets USES=gl.