Bug 230735

Summary: [patch] x11/xorgproto: add LICENSE and clean up Makefile
Product: Ports & Packages Reporter: Samy Mahmoudi <samy.mahmoudi>
Component: Individual Port(s)Assignee: freebsd-x11 mailing list <x11>
Status: New ---    
Severity: Affects Many People CC: zeising
Priority: --- Flags: bugzilla: maintainer-feedback? (x11)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch file generated with svn diff
none
Patch file generated with svn diff none

Description Samy Mahmoudi 2018-08-18 17:14:34 UTC
Created attachment 196323 [details]
Patch file generated with svn diff

- Add LICENSE= MIT
- Replace xorg with X.org in COMMENT 
- Replace a space with a tab in CONFIGURE_ARGS
Comment 1 Niclas Zeising freebsd_committer 2018-08-20 21:06:59 UTC
Hi!
I'm not sure about the license, there are a multitude of COPYING-* files in the upstream source.  While most of them probably are some variety of MIT perhaps we should look closer before adding it to the ports Makefile.

The rest of the changes look good.
Comment 2 Samy Mahmoudi 2018-08-22 21:34:53 UTC
Created attachment 196450 [details]
Patch file generated with svn diff
Comment 3 Samy Mahmoudi 2018-08-22 21:35:34 UTC
Hi Niclas,

Indeed, I should have looked closer: the deleted *proto ports all had their LICENSE set to MIT, except x11-fonts/fontcacheproto and x11/trapproto. The former had its LICENSE set to BSD2CLAUSE and the latter had its LICENSE unset. Fortunately, the file COPYING-trapproto looks like a Carnegie Mellon University (CMU) variant of MIT.

Moreover, COPYING-panoramixproto "is a stub file":

> This package has not yet had its complete licensing          
> information compiled.  Please see the individual source files for
> details on your rights to use and modify this software.                                    
> 
> Please submit updated COPYING files to the Xorg bugzilla:                       
> 
> https://bugs.freedesktop.org/enter_bug.cgi?product=xorg                         
> 
> All licensing questions regarding this software should be directed
> at the Xorg mailing list:                                                              
> 
> http://lists.freedesktop.org/mailman/listinfo/xorg

Although the license included as a header of panoramiXproto.h looks like a variant of MIT, I can not guarantee that other files (if any) provided by this package are licensed under MIT.

So, here is a second draft:

• Add LICENSE= MIT BSD2CLAUSE and LICENSE_COMB= multi
• Replace xorg with X.org in COMMENT 
• Replace a space with a tab in CONFIGURE_ARGS
Comment 4 Samy Mahmoudi 2019-02-07 23:00:08 UTC
Hi Niclas!

I wrote to the Xorg mailing list to ask for help and Adam Jackson answered me:

> Apologies, this was an error on our end. The panoramixproto module
> never had any real content:

> https://gitlab.freedesktop.org/xorg/proto/panoramixproto

> panoramiXproto.h actually came from the xineramaproto module. However
> when building the unified xorgproto module we just imported everything
> named *proto.

> I've removed the COPYING-panoramixproto file from xorgproto, which
> should prevent this confusion in the future. Thanks for bringing this
> to our attention!

So the file COPYING-panoramixproto which raised a last doubt (please reread Comment 3) has just been removed upstream and licensing information is complete thanks to your suggestion and Adam Jackson's help.

Removal: https://gitlab.freedesktop.org/xorg/proto/xorgproto/commit/2505b28a96b17ee394287a74091c42c86e2860fc

Consequently, I suggest to apply the patch of Comment 2:
• Add LICENSE= MIT BSD2CLAUSE and LICENSE_COMB= multi
• Replace xorg with X.org in COMMENT 
• Replace a space with a tab in CONFIGURE_ARGS