Bug 230868

Summary:	Devmatch breaks autoloading of driver
Product:	Base System	Reporter:	Jeremy Faulkner <gldisater>
Component:	misc	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	imp, pete, yuripv
Priority:	---
Version:	CURRENT
Hardware:	amd64
OS:	Any

Description Jeremy Faulkner 2018-08-24 17:32:08 UTC

12-ALPHA3, devmatch tries to load uhid.koums.ko which is not found. In 12-ALPHA2 it properly loaded each separately. Manually loading ums.ko after boot works.

CC'd imp as he committed the devmatch changes.

Comment 1 Warner Losh freebsd_committer

2018-08-25 03:28:39 UTC

I'll take a look at it... likely a simple fix.

Comment 2 Warner Losh freebsd_committer

2018-08-25 04:37:44 UTC

https://reviews.freebsd.org/D16895 should fix.

Comment 3 commit-hook freebsd_committer

2018-08-25 15:48:55 UTC

A commit references this bug:

Author: imp
Date: Sat Aug 25 15:47:53 UTC 2018
New revision: 338314
URL: https://svnweb.freebsd.org/changeset/base/338314

Log:
  Add in a missing newline

  In the conversion, the newline got stripped. It worked fine when there
  was only one module, but not when there are many. Add back the missing
  newline.

  Approved by: re@ (kib)
  PR: 230868
  Differential Revision: https://reviews.freebsd.org/D16895

Changes:
  head/sbin/devmatch/devmatch.c

Comment 4 pete 2018-08-25 18:43:43 UTC

I've rebuild my kernel with a checkout that contains this fix and am seeing the same behavior (ums.ko not loading at boot automatically).  

loading it manually works and my usb mouse is detected.

Comment 5 Yuri Pankov 2018-08-25 18:53:47 UTC

Pete, please note that the fix is in sbin/devmatch, not kernel itself.

Comment 6 pete 2018-08-25 20:08:32 UTC

in my haste i def made that mistake -thanks Yuri!  i'm all set now :)

Comment 7 Jeremy Faulkner 2018-08-26 19:30:57 UTC

Thanks imp@. Sorry I couldn't test it sooner, I was doing a prolonged test to attempt to reproduce a panic for drm-next.