Bug 230878

Summary: security/sancp: Fix build with Clang 6
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (bofh)
tobik: merge-quarterly-
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
sancp.diff tobik: maintainer-approval?

Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 01:49:19 UTC 
security/sancp: Fix build with Clang 6

The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.

http://beefy12.nyi.freebsd.org/data/head-amd64-default/p477696_s338122/logs/errors/sancp-1.6.1_6.log

--
Generated by ports-mgmt/freebsd-bugzilla-cli - v0.15.0.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 01:52:24 UTC 
Created attachment 196512 [details]
sancp.diff

> --
> Generated by ports-mgmt/freebsd-bugzilla-cli - v0.15.0.

First and last time doing that...  Apologies for the extra noise
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-08 08:54:25 UTC 
A commit references this bug:

Author: tobik
Date: Sat Sep  8 08:53:37 UTC 2018
New revision: 479234
URL: https://svnweb.freebsd.org/changeset/ports/479234

Log:
  security/sancp: Fix build with Clang 6

  In file included from build_acl.cc:2:
  In file included from ./sancp.h:47:
  In file included from ./gvars.h:6:
  ./pcapFileHandle.h:19:30: error: constant expression evaluates to 212 which cannot be narrowed to type 'char' [-Wc++11-narrowing]
  const char pcap_header[] = { 0xd4,0xc3,0xb2,0xa1,0x02,0x00,0x04,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x20,0x4e,0x00,0x00,0x01,0x00,0x00,0x00 };
                               ^~~~

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p477696_s338122/logs/errors/sancp-1.6.1_6.log

  - Make sure CXXFLAGS is respected

  PR:		230878
  Submitted by:	tobik
  Approved by:	bofh (maintainer timeout, 2 weeks)

Changes:
  head/security/sancp/Makefile