Summary: | textproc/scim-bridge: Fix build with Clang 6 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||||
Component: | Individual Port(s) | Assignee: | Ashish SHUKLA <ashish> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | ndowens04, rene | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ashish) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/scim-bridge-0.4.16_2.log | ||||||||
Attachments: |
|
Description
Tobias Kortkamp
2018-08-25 14:35:30 UTC
Created attachment 196531 [details]
textproc__scim-bridge.diff
A commit references this bug: Author: tobik Date: Sat Sep 8 09:19:13 UTC 2018 New revision: 479238 URL: https://svnweb.freebsd.org/changeset/ports/479238 Log: textproc/scim-bridge: Mark as broken on systems using Clang 6 scim-bridge-agent-signal-listener.cpp:67:9: error: no matching function for call to 'send' send (pipe_in, '\0', sizeof (char), MSG_NOSIGNAL); ^~~~ /usr/include/sys/socket.h:680:9: note: candidate function not viable: no known conversion from 'char' to 'const void *' for 2nd argument ssize_t send(int, const void *, size_t, int); ^ There was no maintainer feedback and it is doubtful that my proposed fix in the PR is correct. PR: 230891 Changes: head/textproc/scim-bridge/Makefile Can this be closed? Seems a commit has referenced it (In reply to Nathan from comment #3) No, read the commit message. It's not fixed. Probably an update to 0.4.17 [1] will fix the build with Clang 6 too. [1] https://github.com/scim-im/scim-bridge With 10.4 EOL this port now does not build anywhere. Should we deprecate it? Hi Tobias, Appreciate your taking look at this PR, and sorry for the lack of timely follow-up on my part. (In reply to Tobias Kortkamp from comment #4) I'm able to build latest version with clang 6.0.0 on my 11.2-amd64 desktop, although have yet to perform a poudriere build. (In reply to Tobias Kortkamp from comment #5) Only if it doesn't build on 11.x, and 12.x after update. Thanks! Created attachment 198961 [details]
Update to 0.4.17
Update to 0.4.17 yet to be poudriere tested though.
FYI the port was now marked as deprecated with expiration date of 2019-05-08 by antoine@ in ports r498264. Any news on this, or should we remove this port instead? A commit references this bug: Author: ashish Date: Sat Aug 17 06:49:31 UTC 2019 New revision: 509138 URL: https://svnweb.freebsd.org/changeset/ports/509138 Log: Remove expired port: 2019-05-08 textproc/scim-bridge: Broken for more than 6 months PR: 230891 Changes: head/MOVED head/textproc/Makefile head/textproc/scim-bridge/ (In reply to Rene Ladan from comment #9) Sorry for inactivity on my part. I went ahead and removed it. |