|Summary:||[patch] x11-wm/libcompizconfig: correct LICENSE; add a missing dependency and option NLS|
|Product:||Ports & Packages||Reporter:||Samy Mahmoudi <samy.mahmoudi>|
|Component:||Individual Port(s)||Assignee:||freebsd-ports-bugs (Nobody) <ports-bugs>|
|Status:||In Progress ---|
|Severity:||Affects Some People||CC:||freebsd-ports, meta|
Description Samy Mahmoudi 2018-08-26 15:41:56 UTC
Created attachment 196570 [details] Patch file generated with svn diff Hi, • Correct LICENSE (GPLv2 ---> GPLv2+) • Add a missing dependency • Add option NLS • Regenerate a patch file • Bump PORTREVISION (Makefile changed to enable a compile-time option)
Comment 1 Koichiro Iwao 2019-02-11 16:56:54 UTC
Comment 2 Samy Mahmoudi 2019-02-11 22:29:04 UTC
(In reply to Koichiro Iwao from comment #1) Commit under maintainer timeout already requested for this patch and various others. As I was not using neither poudriere nor portlint at that time, I provided a patch incorrect in some way, which results in one of these requests being postponed. To ease in review, I cancelled all the other requests so that I could check myself the patches with poudriere/portlint rather than losing committers' time...
Comment 3 Koichiro Iwao 2019-02-12 02:34:25 UTC
testbuild by poudriere failed. USES=gettext seems to be needed.
Comment 4 Samy Mahmoudi 2019-02-12 08:54:50 UTC
(In reply to Koichiro Iwao from comment #3) I will try to sort out this problem today.