Bug 230942

Summary: games/ksirk-kde4: fails to build with clang 7
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: freebsd-kde (Team) <kde>
Status: Closed FIXED    
Severity: Affects Only Me CC: adridg
Priority: --- Keywords: needs-patch
Version: LatestFlags: bugzilla: maintainer-feedback? (kde)
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 230355    

Description Jan Beich freebsd_committer 2018-08-27 14:21:48 UTC
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 games/ksirk-kde4
[...]
ksirk/iris/src/xmpp/xmpp-im/filetransfer.cpp:399:57: error: ordered comparison between pointer and zero ('const void *' and 'int')
        return d->list.contains(const_cast<FileTransfer*>(ft)) > 0;
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

http://package18.nyi.freebsd.org/data/headamd64PR230355gnucxx98-default/2018-08-26_10h16m34s/logs/errors/ksirk-kde4-4.14.3_5.log
Comment 1 commit-hook freebsd_committer 2018-08-29 20:49:53 UTC
A commit references this bug:

Author: adridg
Date: Wed Aug 29 20:49:03 UTC 2018
New revision: 478418
URL: https://svnweb.freebsd.org/changeset/ports/478418

Log:
  Clang7 fixes for some old soon-to-be-deprecated KDE4 games.

  PR:		230938 230942
  Reported by:	jbeich

Changes:
  head/games/kolf-kde4/files/
  head/games/kolf-kde4/files/patch-kcomboboxdialog.cpp
  head/games/kolf-kde4/files/patch-newgame.cpp
  head/games/ksirk-kde4/files/
  head/games/ksirk-kde4/files/patch-ksirk_iris_src_xmpp_xmpp-im_filetransfer.cpp