Bug 230943

Summary: games/khangman-kde4: fails to build with clang 7
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: freebsd-kde (group) <kde>
Status: Closed FIXED    
Severity: Affects Only Me CC: adridg
Priority: --- Keywords: needs-patch
Version: LatestFlags: bugzilla: maintainer-feedback? (kde)
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 230355    

Description Jan Beich freebsd_committer freebsd_triage 2018-08-27 14:23:08 UTC
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 games/khangman-kde4
[...]
src/desktop/khangmanview.cpp:513:45: error: ordered comparison between pointer and zero ('const void *' and 'int')
        if (m_missedLetters.contains(guess) > 0) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
src/desktop/khangmanview.cpp:530:38: error: ordered comparison between pointer and zero ('const void *' and 'int')
        if (goodWord.contains(guess) > 0) {
            ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

http://package18.nyi.freebsd.org/data/headamd64PR230355gnucxx98-default/2018-08-26_10h16m34s/logs/errors/khangman-kde4-4.14.3_3.log
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-28 11:06:12 UTC
A commit references this bug:

Author: adridg
Date: Tue Aug 28 11:05:52 UTC 2018
New revision: 478299
URL: https://svnweb.freebsd.org/changeset/ports/478299

Log:
  Fix build with clang7

  PR:		230943
  Reported by:	jbeich

Changes:
  head/games/khangman-kde4/files/
  head/games/khangman-kde4/files/patch-src_desktop_khangmanview.cpp