Bug 230958

Summary: databases/libdrizzle-redux: Fix build with Clang 6
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/libdrizzle-redux-5.1.4_2.log
Attachments:
Description Flags
databases__libdrizzle-redux.diff none

Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-27 19:35:08 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.

The problem is that Clang 6 has switched to C++14 by default over
C++98 (see [1]) causing all sorts of regressions.  Often this can
easily be fixed by applying a small amount of trivial patches.

We can apply them to the ports tree but if possible (and assuming
upstream development has not ceased), they should be upstreamed to
reduce future maintainance work.

[1] http://releases.llvm.org/6.0.0/tools/clang/docs/ReleaseNotes.html#c-language-changes-in-clang
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-27 19:35:24 UTC 
Created attachment 196610 [details]
databases__libdrizzle-redux.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-10 15:21:29 UTC 
A commit references this bug:

Author: tobik
Date: Mon Sep 10 15:20:47 UTC 2018
New revision: 479430
URL: https://svnweb.freebsd.org/changeset/ports/479430

Log:
  databases/libdrizzle-redux: Fix build with Clang 6

  libdrizzle/binlog.cc:319:48: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
                            "packet size error:%"PRIu32":%"PRIu32, con->packet_size, binlog_event->length);
                                                 ^

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/libdrizzle-redux-5.1.4_2.log

  PR:		230958
  Approved by:	jim@ohlste.in (maintainer timeout, 2 weeks)

Changes:
  head/databases/libdrizzle-redux/files/
  head/databases/libdrizzle-redux/files/patch-libdrizzle_binlog.cc
  head/databases/libdrizzle-redux/files/patch-libdrizzle_field.cc
  head/databases/libdrizzle-redux/files/patch-libdrizzle_statement__param.cc