Bug 230965

Summary: net/remmina-plugins: r478203 breaks portscout
Product: Ports & Packages Reporter: Dmitri Goutnik <dmgk>
Component: Individual Port(s)Assignee: Ben Woods <woodsb02>
Status: Closed FIXED    
Severity: Affects Only Me CC: woodsb02
Priority: --- Keywords: patch
Version: LatestFlags: woodsb02: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch file woodsb02: maintainer-approval+

Description Dmitri Goutnik freebsd_committer freebsd_triage 2018-08-27 22:52:17 UTC 
Created attachment 196621 [details]
patch file

After r478203:

$ make -C /usr/ports/net/remmina-plugins -V MASTER_SITES
 https://gitlab.com/Remmina/Remmina/repository/65d552c9becc957cae124ab5c26562cf22c052b9/archive.tar.gz?dummy=/

That leading space character in MASTER_SITES breaks "portscout rebuild":

Can't locate object method "host" via package "URI::_generic" at /usr/local/lib/perl5/site_perl/Portscout/DataSrc/Ports.pm line 460
Comment 1 Ben Woods freebsd_committer freebsd_triage 2018-08-27 23:53:01 UTC 
Comment on attachment 196621 [details]
patch file

Looks good, thanks for finding the fix.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-28 09:36:58 UTC 
A commit references this bug:

Author: woodsb02
Date: Tue Aug 28 09:36:55 UTC 2018
New revision: 478294
URL: https://svnweb.freebsd.org/changeset/ports/478294

Log:
  net/remmina-plugins: Fix portscout

  Before this change, the output of "make -V MASTER_SITES" would start
  with a leading space character, which would break portscout.

  PR:		230965
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/net/remmina-plugins/Makefile
Comment 3 Ben Woods freebsd_committer freebsd_triage 2018-08-28 09:37:46 UTC 
Committed, thanks!