Bug 231089

Summary:	net-mgmt/librenms typo's in default.inc.php
Product:	Ports & Packages	Reporter:	Dries Michiels <driesm>
Component:	Individual Port(s)	Assignee:	Dan Langille <dvl>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	dvl
Priority:	---	Keywords:	easy
Version:	Latest	Flags:	bugzilla: maintainer-feedback? (bofh)
Hardware:	Any
OS:	Any

Description Dries Michiels freebsd_committer

2018-09-02 09:19:49 UTC

There are two typo's in the default PHP included configuration:

1: 
$config['nmap']           = '/usr/localbin/nmap';
Should be
$config['nmap']           = '/usr/local/bin/nmap';

2:
$config['mtr']            = '/usr/local/bin/mtr';
Should be
$config['mtr']            = '/usr/local/sbin/mtr';

Comment 1 Dries Michiels freebsd_committer

2018-09-02 10:44:43 UTC

Also,

Should the enry in .env

LIBRENMS_USER=librenms
 
not be

LIBRENMS_USER=www

as specified in config.php also?

Comment 2 Dan Langille freebsd_committer

2018-09-02 13:51:59 UTC

(In reply to Dries Michiels from comment #0)
Yes, those path corrections are appropriate.

Did you discover this via visual inspection? Was LibreNMS producing an error?

Comment 3 Dan Langille freebsd_committer

2018-09-02 13:53:15 UTC

(In reply to Dries Michiels from comment #1)
Yes, I think so.

Comment 4 Dries Michiels freebsd_committer

2018-09-02 14:03:43 UTC

It was not producing an error altough I saw this through visual inspection of the recent commit to get it to 1.42 :)

Comment 5 commit-hook freebsd_committer

2018-09-02 14:07:00 UTC

A commit references this bug:

Author: dvl
Date: Sun Sep  2 14:06:55 UTC 2018
New revision: 478792
URL: https://svnweb.freebsd.org/changeset/ports/478792

Log:
  Correct paths for nmap and mtr in patch for includes/defaults.inc.php
  Correct user in patch for .env.example

  PR:		231089
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com>

Changes:
  head/net-mgmt/librenms/Makefile
  head/net-mgmt/librenms/files/patch-.env.example
  head/net-mgmt/librenms/files/patch-includes_defaults.inc.php

Comment 6 Dan Langille freebsd_committer

2018-09-02 14:09:09 UTC

Thank you.

Comment 7 Dries Michiels freebsd_committer

2018-09-02 14:17:46 UTC

Thank you for updating it to newest version!