Bug 231399

Summary: [patch] x11-toolkits/wxgtk30: fix dependencies, add NOTIFY option, address portlint error
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: portmaster
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (portmaster)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.diff
none
Portlint -AC output none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2018-09-16 13:16:44 UTC
Created attachment 197142 [details]
Makefile.diff

- Add USES+=gnome, gl (requested by bsd.port.mk with DEVELOPER=yes in /etc/make.conf)
- Add NOTIFY option for notifications support via libnotify; without this change it's autodetected and automatically picked up if present (without dependency record)
- Append libGL / cairo / gdk-pixbuf2 port dependencies (libGL is needed by libGLU and cairo / gdk-pixbuf2 - by gtk20, so there will be no visible change).
- Move DISTVERSIONPREFIX before PORTREVISION as suggested by portlint(1).
- Bump PORTREVISION due to dependencies / options change.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2018-09-16 13:18:24 UTC
Created attachment 197143 [details]
Portlint -AC output
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-28 07:06:26 UTC
A commit references this bug:

Author: tobik
Date: Mon Jan 28 07:06:07 UTC 2019
New revision: 491458
URL: https://svnweb.freebsd.org/changeset/ports/491458

Log:
  x11-toolkits/wxgtk30: Add NOTIFY option

  Without this libnotify might be autodetected and automatically
  picked up if present in the build environment.

  - Add some missing dependencies
  - Pet portlint
  - Reset maintainer after the long timeout

  PR:		231399
  Submitted by:	avos
  Approved by:	portmaster@bsdforge.com (maintainer timeout, ~4 months)

Changes:
  head/x11-toolkits/wxgtk30/Makefile