Bug 231584

Summary: devel/qt5-buildtools: fix build on architectures using base GCC
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: freebsd-kde (Nobody) <kde>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, pkubaj, tcberner
Priority: --- Flags: tcberner: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 231542, 231963    
Bug Blocks:    
Attachments:
Description Flags
patch
none
better fix none

Description Piotr Kubaj freebsd_committer 2018-09-22 13:10:46 UTC
Created attachment 197346 [details]
patch

Similarly to devel/qt5-qmake, this patch redefines mkspecs to allow building with gcc7 port when base GCC is present.

It also adds USES=compiler:c++17-lang, since -std=c++1z is used during compilation.

Tested on powerpc64 and on amd64 with clang.
Comment 1 Piotr Kubaj freebsd_committer 2018-09-22 17:52:24 UTC
Created attachment 197359 [details]
better fix

Better fix, assumes there are already patches from 231542.
Comment 2 commit-hook freebsd_committer 2018-10-14 08:02:21 UTC
A commit references this bug:

Author: tcberner
Date: Sun Oct 14 08:01:23 UTC 2018
New revision: 482034
URL: https://svnweb.freebsd.org/changeset/ports/482034

Log:
  qt5: Fix build on GCC based architectures.

  PR:		231584
  PR:		231677
  PR:		231685
  PR:		231830
  PR:		231955
  PR:		231905
  PR:		231892
  PR:		231684
  PR:		231958
  PR:		231960
  PR:		231818
  PR:		231542
  PR:		231860
  PR:		231681
  PR:		231963
  PR:		231891
  PR:		231966
  PR:		231904
  PR:		231676
  PR:		231819
  PR:		231956
  PR:		231680
  PR:		231957
  PR:		231903
  PR:		231901
  PR:		231667
  PR:		231861
  Submitted by:	 Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/Mk/Uses/qt-dist.mk
  head/accessibility/qt5-speech/Makefile
  head/comms/qt5-sensors/Makefile
  head/comms/qt5-serialport/Makefile
  head/databases/qt5-sql/Makefile
  head/devel/qt5/Makefile.sqldrivers
  head/devel/qt5/files/extra-patch-mkspecs_common_g++-base.conf
  head/devel/qt5/files/extra-patch-mkspecs_common_gcc-base.conf
  head/devel/qt5-assistant/Makefile
  head/devel/qt5-buildtools/Makefile
  head/devel/qt5-concurrent/Makefile
  head/devel/qt5-core/Makefile
  head/devel/qt5-dbus/Makefile
  head/devel/qt5-designer/Makefile
  head/devel/qt5-help/Makefile
  head/devel/qt5-linguisttools/Makefile
  head/devel/qt5-location/Makefile
  head/devel/qt5-qdbus/Makefile
  head/devel/qt5-qmake/Makefile
  head/devel/qt5-script/Makefile
  head/devel/qt5-scripttools/Makefile
  head/devel/qt5-testlib/Makefile
  head/devel/qt5-uitools/Makefile
  head/graphics/qt5-imageformats/Makefile
  head/graphics/qt5-opengl/Makefile
  head/graphics/qt5-svg/Makefile
  head/lang/qt5-qml/Makefile
  head/multimedia/qt5-multimedia/Makefile
  head/net/qt5-network/Makefile
  head/print/qt5-printsupport/Makefile
  head/sysutils/qt5-qtpaths/Makefile
  head/textproc/qt5-xml/Makefile
  head/textproc/qt5-xmlpatterns/Makefile
  head/www/qt5-webchannel/Makefile
  head/x11/qt5-x11extras/Makefile
  head/x11-toolkits/qt5-gui/Makefile
  head/x11-toolkits/qt5-quick/Makefile
  head/x11-toolkits/qt5-quickcontrols/Makefile
  head/x11-toolkits/qt5-quickcontrols2/Makefile
  head/x11-toolkits/qt5-virtualkeyboard/Makefile
  head/x11-toolkits/qt5-widgets/Makefile
Comment 3 Tobias C. Berner freebsd_committer 2018-10-14 08:05:06 UTC
Committed. Thanks