Bug 231595

Summary: graphics/animorph: add USES=compiler:gcc-c++11-lib localbase:ldflags
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: jbeich, linimon, ndowens04, pkubaj
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2018-09-22 17:25:30 UTC
Created attachment 197356 [details]
patch

This patch does three things:
1) fix build with mips, mips64 and powerpc64 by using compiler:gcc-c++11-lib (there's no compiler option for gnu++03)
2) remove USE_GCC, it's already set up by compiler:gcc-c++11-lib,
3) replace manual CPPFLAGS and LDFLAGS with localbase:ldflags.

Tested on powerpc64 and amd64.
Comment 1 Nathan 2018-09-23 03:19:19 UTC
Using compiler:gcc-c++11-lib will break it on mips*, as it will try to pull GCC(which is not available on mips)
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-09-23 08:09:26 UTC
(In reply to Nathan from comment #1)
Hm, ok, that's bad.

But it's broken anyway right now on those platforms. At least we can fix powerpc64 and when newer GCC is available for mips*, they will work too.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2018-09-23 23:01:00 UTC
(In reply to Nathan from comment #1)

I'd have to say I'm skeptical anyone is using this port on mips*.
Comment 4 Nathan 2018-09-23 23:09:52 UTC
(In reply to Mark Linimon from comment #3)
compiler:c++11 or anything like this, will pull gcc7, which is not available on mips. I can't test powerpc or anything. I'm hoping gcc8 will work on mips/mips64
Comment 5 Nathan 2018-09-23 23:18:46 UTC
(In reply to Nathan from comment #4)
Update seems gcc8 is also marked as IGNORED
Comment 6 Jan Beich freebsd_committer freebsd_triage 2018-10-28 10:06:40 UTC
-std=gnu++03 is gone after ports r483249
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2019-05-11 21:53:40 UTC
Works fine now.