Bug 231631
| Summary: | www/squid3 does not build with ECAP option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Thomas Zander <riggs> | ||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | timp87, w.schwarzenfeld | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
riggs: merge-quarterly- |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 197460 [details]
svn-diff-squid3
If I am right, this should fix it.
Reporter is committer, assign accordingly Comment on attachment 197460 [details]
svn-diff-squid3
Changesets fixing build/run/package errors are:
Approved by: portmgr (blanket: build, run or package fix)
(In reply to Thomas Zander from comment #0) What OS do you use? I can not reproduce this error on FreeBSD 11.2-RELEASE amd64 (In reply to timp87 from comment #4) This is in an 11.2-RELEASE-p4 amd64 poudriere jail. Attachment #197460 [details] fixes this problem by explicitly returning the bool type. Are you okay if I commit this? (In reply to Thomas Zander from comment #5) Sure! A commit references this bug: Author: riggs Date: Sat Sep 29 14:39:17 UTC 2018 New revision: 480908 URL: https://svnweb.freebsd.org/changeset/ports/480908 Log: Fix build with ECAP OPTION PR: 231631 Submitted by: w.schwarzenfeld@utanet.at (patch file) Reported by: riggs Approved by: timp87@gmail.com (maintainer) Changes: head/www/squid3/Makefile head/www/squid3/files/patch-ServiceRep.cc Committed, thanks! Not MFH'ed to 2018Q3 since there is no www/squid3 port. |
When building squid3 3.5.28 with ECAP option, the build breaks at: ... libtool: compile: c++ -DHAVE_CONFIG_H -I../../.. -I../../../include -I../../../lib -I../../../src -I../../../include -I/usr/include -I/usr/include -I../../../libltdl -I/usr/include -I/usr/local/include -I/usr/local/include -I/usr/include -I/usr/include -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wno-unknown-warning-option -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -Wno-dynamic-class-memaccess -I/usr/local/include -MT libsquid_ecap_la-Config.lo -MD -MP -MF .deps/libsquid_ecap_la-Config.Tpo -c Config.cc -o libsquid_ecap_la-Config.o >/dev/null 2>&1 --- libsquid_ecap_la-ServiceRep.lo --- ServiceRep.cc:237:12: error: no viable conversion from returned value of type 'const Adaptation::Ecap::ServiceRep::AdapterService' (aka 'const shared_ptr<libecap::adapter::Service>') to function return type 'bool' return theService; ^~~~~~~~~~ 1 error generated. *** [libsquid_ecap_la-ServiceRep.lo] Error code 1