Summary: | [NEW PORT] math/cocoalib: C++ library for doing computations in commutative algebra | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Lorenzo Salvadore <salvadore> | ||||||||||||||||||||
Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||||||||||||||
Status: | Closed FIXED | ||||||||||||||||||||||
Severity: | Affects Only Me | CC: | ndowens04, swills | ||||||||||||||||||||
Priority: | --- | ||||||||||||||||||||||
Version: | Latest | ||||||||||||||||||||||
Hardware: | Any | ||||||||||||||||||||||
OS: | Any | ||||||||||||||||||||||
Bug Depends on: | 231186, 231208 | ||||||||||||||||||||||
Bug Blocks: | 231806 | ||||||||||||||||||||||
Attachments: |
|
Description
Lorenzo Salvadore
2018-09-29 19:49:52 UTC
Created attachment 197606 [details]
shar file for cocoalib
This port depends optionally on: - frobby: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231208 - gfanlib: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231186 (which in turn needs cddlib: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231161 ) - libnormaliz: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231806 Comment on attachment 197606 [details]
shar file for cocoalib
XLICENSE_DISTFILES_GFDL= ${WRKSRC}/doc
is not aligned correctly
XOPTIONS_DEFINE= DOCS \
X EXAMPLES \
X FROBBY \
X GFAN \
X GSL \
X NORMALIZ \
X SMALLDEG \
X TEST
Dont need all \
Could make them look something like:
DOCS EXAMPLES FROBBY GFAN \
GSL NORMALIZ SMALLDEG TEST
Move the following below BUILD_DEPENDS with space between( variables not related to OPTIONS don't need to go below options area:
USES+= shebangfix
SHEBANG_GLOB= *.sh
USES+= tar:tgz
Also eliminate one USES and do:
USES= shebangfix tar:tgz
Created attachment 197620 [details]
cocoalib shar file - correction 1
I did the corrections as following:
- I could not align correctly the line "LICENSE_DISTFILES_GFDL= ${WRKSRC}/doc" because to me it looks aligned correctly: the first L is under the first L of the above line (LICENSE_DISTFILES_GPLv3+ = ${WRKSRC}/src ${WRKSRC}/include) and the dollar sign is under the first dollar sign of the above line. What should I correct? Is it possible that the mistake that you found is related to the above line, where portlint suggested me to put a space between the plus sign and the equal sign to make clear that the plus refers to the license name?
- I put the options on two lines only as you suggested.
- I put both USES flags on the same line and moved it earlier. I tried after BUILD_DEPENDS, but portlint complained it wanted to know about flavors before, so I put in order BUILD_DEPENDS, FLAVORS, FLAVOR?, USES. Also, portlint did not appreciate SHEBANG_GLOB put together with USES, so I had to put it later.
Comment on attachment 197620 [details] cocoalib shar file - correction 1 Move : SHEBANG_GLOB= *.sh back under USES but put a space in between and portlint won't complain LICENSE_DISTFILES are license files that are zip'd,gz, etc https://www.freebsd.org/doc/en/books/porters-handbook/licenses.html#licenses-license_distfiles-ex1 So those lines don't need to be there. Though if the PD file does exist(not archived) then it should look like LICENSE_FILE_PD Created attachment 197639 [details] cocoalib shar file - correction 2 I did as you suggested for SHEBANG_GLOB and it worked. As for the licenses, I am sorry, but I am not sure to have understood correctly. You tell me "LICENSE_DISTFILES are license files that are zip'd,gz, etc": I think you meant LICENSE_FILE (the handbook defines LICENSE_FILE as "full path to the file containing the license text" and LICENSE_DISTFILES as "the distribution files to which the licenses apply"). Hence what you mean is that it is not necessary to specify values for the variable LICENCE_FILE when the license is standard? This seems to me to be in conflict with the first example of https://www.freebsd.org/doc/en/books/porters-handbook/licenses.html#licenses-license_distfiles-ex1 and I see that many ports do specify those values (for example editor/openoffice-devel, games/supertuxkart, www/falkon), although I also found counterexamples. Are all those ports wrong? In the new shar file, I removed the LICENSE_FILE_whatever lines, hoping that it was the requested correction. Created attachment 197675 [details] cocoalib shar file - correction 3 Style corrections following suggestions from bug #231161. Correction of a mistake about a wrong dependency on readline. I also added again the LICENSE_FILE_whatever lines since in bug #231161 I had such a line and a committer kept it. I suspend temporarily the request because I am working to simplify the port. I will soon send the new simplified version. Created attachment 197692 [details]
cocoalib shar file - correction 4
Port has been simplified and is now much more readable.
Created attachment 197715 [details]
cocoalib shar file - correction 5
One more style improvement, this time concerning the TEST option, which now takes advantage of TEST_TARGET.
(Sorry for the multiple corrections, but this port is complex and I am still at my first ports. I think it should be good now.)
Created attachment 197766 [details]
cocoalib shar file - correction 6
Minor correction related to a wrong dependency on ccdlib.
Created attachment 197907 [details] cocoalib shar file - correction 7 I misunderstood the meaning of LICENSE_DISTFILES_whatever: now I have it clear and I understood Nathan's comment #5, so I removed the lines that needed to be removed. Created attachment 201759 [details] cocoalib shar file - correction 8 I made some corrections based on remarks reported in bug #231806. Committed, thanks! A commit references this bug: Author: swills Date: Wed Mar 20 11:15:59 UTC 2019 New revision: 496332 URL: https://svnweb.freebsd.org/changeset/ports/496332 Log: math/cocoalib: create port CoCoALib is a C++ library for Computations in Commutative Algebra, focused mainly on polynomial rings, ideals, Groebner basis and similar topics. WWW: http://cocoa.dima.unige.it PR: 231807 Submitted by: Lorenzo Salvadore <phascolarctos@protonmail.ch> Changes: head/math/Makefile head/math/cocoalib/ head/math/cocoalib/Makefile head/math/cocoalib/distinfo head/math/cocoalib/files/ head/math/cocoalib/files/Makefile.AlgebraicCore head/math/cocoalib/files/Makefile.tests head/math/cocoalib/files/patch-src_AlgebraicCore_TmpLDP.C head/math/cocoalib/pkg-descr head/math/cocoalib/pkg-plist |